Re: [PATCH 3/8] pstore: Add persistent function tracing

2012-07-17 Thread Anton Vorontsov
On Tue, Jul 17, 2012 at 05:38:22PM -0400, Steven Rostedt wrote: [...] > > > BTW, can any of the called functions go into module code that can be > > > removed? If so, then this is not safe at all. Normal function tracing > > > can not be synced in a preemptible kernel. > > > > Um. Yes,

Re: [PATCH 3/8] pstore: Add persistent function tracing

2012-07-17 Thread Steven Rostedt
On Tue, 2012-07-17 at 13:01 -0700, Anton Vorontsov wrote: > On Tue, Jul 17, 2012 at 03:38:18PM -0400, Steven Rostedt wrote: > [...] > > > +void notrace pstore_ftrace_call(unsigned long ip, unsigned long > > > parent_ip) > > > > BTW, you can make the entire file 'notrace' without adding

Re: [PATCH 3/8] pstore: Add persistent function tracing

2012-07-17 Thread Anton Vorontsov
On Tue, Jul 17, 2012 at 03:38:18PM -0400, Steven Rostedt wrote: [...] > > +void notrace pstore_ftrace_call(unsigned long ip, unsigned long parent_ip) > > BTW, you can make the entire file 'notrace' without adding annotations > by including in the Makefile: > > CFLAGS_REMOVE_ftrace.o = -pg

Re: [PATCH 3/8] pstore: Add persistent function tracing

2012-07-17 Thread Steven Rostedt
On Mon, 2012-07-09 at 17:10 -0700, Anton Vorontsov wrote: > --- /dev/null > +++ b/fs/pstore/ftrace.c > @@ -0,0 +1,35 @@ > +/* > + * Copyright 2012 Google, Inc. > + * > + * This software is licensed under the terms of the GNU General Public > + * License version 2, as published by the Free

Re: [PATCH 3/8] pstore: Add persistent function tracing

2012-07-17 Thread Steven Rostedt
On Mon, 2012-07-09 at 17:10 -0700, Anton Vorontsov wrote: --- /dev/null +++ b/fs/pstore/ftrace.c @@ -0,0 +1,35 @@ +/* + * Copyright 2012 Google, Inc. + * + * This software is licensed under the terms of the GNU General Public + * License version 2, as published by the Free Software

Re: [PATCH 3/8] pstore: Add persistent function tracing

2012-07-17 Thread Anton Vorontsov
On Tue, Jul 17, 2012 at 03:38:18PM -0400, Steven Rostedt wrote: [...] +void notrace pstore_ftrace_call(unsigned long ip, unsigned long parent_ip) BTW, you can make the entire file 'notrace' without adding annotations by including in the Makefile: CFLAGS_REMOVE_ftrace.o = -pg Actually it

Re: [PATCH 3/8] pstore: Add persistent function tracing

2012-07-17 Thread Steven Rostedt
On Tue, 2012-07-17 at 13:01 -0700, Anton Vorontsov wrote: On Tue, Jul 17, 2012 at 03:38:18PM -0400, Steven Rostedt wrote: [...] +void notrace pstore_ftrace_call(unsigned long ip, unsigned long parent_ip) BTW, you can make the entire file 'notrace' without adding annotations by

Re: [PATCH 3/8] pstore: Add persistent function tracing

2012-07-17 Thread Anton Vorontsov
On Tue, Jul 17, 2012 at 05:38:22PM -0400, Steven Rostedt wrote: [...] BTW, can any of the called functions go into module code that can be removed? If so, then this is not safe at all. Normal function tracing can not be synced in a preemptible kernel. Um. Yes, psinfo-write_buf()

[PATCH 3/8] pstore: Add persistent function tracing

2012-07-09 Thread Anton Vorontsov
With this support kernel can save function call chain log into a persistent ram buffer that can be decoded and dumped after reboot through pstore filesystem. It can be used to determine what function was last called before a reset or panic. We store the log in a binary format and then decode it

[PATCH 3/8] pstore: Add persistent function tracing

2012-07-09 Thread Anton Vorontsov
With this support kernel can save function call chain log into a persistent ram buffer that can be decoded and dumped after reboot through pstore filesystem. It can be used to determine what function was last called before a reset or panic. We store the log in a binary format and then decode it