Re: [PATCH 3/8 v2] dma: k3dma: Upgrade k3dma driver to support hisi_asp_dma hardware

2019-01-04 Thread Manivannan Sadhasivam
On Fri, Jan 04, 2019 at 09:44:17PM -0800, John Stultz wrote: > On Fri, Jan 4, 2019 at 9:39 PM Manivannan Sadhasivam > wrote: > > > > On Fri, Jan 04, 2019 at 09:22:46PM -0800, John Stultz wrote: > > > On Fri, Jan 4, 2019 at 7:42 PM Manivannan Sadhasivam > > > wrote: > > > > On Fri, Jan 04, 2019 at

Re: [PATCH 3/8 v2] dma: k3dma: Upgrade k3dma driver to support hisi_asp_dma hardware

2019-01-04 Thread John Stultz
On Fri, Jan 4, 2019 at 9:39 PM Manivannan Sadhasivam wrote: > > On Fri, Jan 04, 2019 at 09:22:46PM -0800, John Stultz wrote: > > On Fri, Jan 4, 2019 at 7:42 PM Manivannan Sadhasivam > > wrote: > > > On Fri, Jan 04, 2019 at 12:56:23PM -0800, John Stultz wrote: > > > > From: Youlin Wang > > > > >

Re: [PATCH 3/8 v2] dma: k3dma: Upgrade k3dma driver to support hisi_asp_dma hardware

2019-01-04 Thread Manivannan Sadhasivam
On Fri, Jan 04, 2019 at 09:22:46PM -0800, John Stultz wrote: > On Fri, Jan 4, 2019 at 7:42 PM Manivannan Sadhasivam > wrote: > > On Fri, Jan 04, 2019 at 12:56:23PM -0800, John Stultz wrote: > > > From: Youlin Wang > > > > > > There is an new "hisi-pcm-asp-dma-1.0" device added in > > > "arch/arm6

Re: [PATCH 3/8 v2] dma: k3dma: Upgrade k3dma driver to support hisi_asp_dma hardware

2019-01-04 Thread John Stultz
On Fri, Jan 4, 2019 at 7:42 PM Manivannan Sadhasivam wrote: > On Fri, Jan 04, 2019 at 12:56:23PM -0800, John Stultz wrote: > > From: Youlin Wang > > > > There is an new "hisi-pcm-asp-dma-1.0" device added in > > "arch/arm64/boot/dts/hisilicon/hi3660.dtsi". > > So we have to add a matching id in t

Re: [PATCH 3/8 v2] dma: k3dma: Upgrade k3dma driver to support hisi_asp_dma hardware

2019-01-04 Thread Manivannan Sadhasivam
Hi John, On Fri, Jan 04, 2019 at 12:56:23PM -0800, John Stultz wrote: > From: Youlin Wang > > There is an new "hisi-pcm-asp-dma-1.0" device added in > "arch/arm64/boot/dts/hisilicon/hi3660.dtsi". > So we have to add a matching id in the driver file: > .compatible = "hisilicon,hisi-pcm-asp-dma-1

[PATCH 3/8 v2] dma: k3dma: Upgrade k3dma driver to support hisi_asp_dma hardware

2019-01-04 Thread John Stultz
From: Youlin Wang There is an new "hisi-pcm-asp-dma-1.0" device added in "arch/arm64/boot/dts/hisilicon/hi3660.dtsi". So we have to add a matching id in the driver file: .compatible = "hisilicon,hisi-pcm-asp-dma-1.0" And also hisi-pcm-asp dma device needs no setting to the clock. So we skip thi