Re: [PATCH 3/9] drivers/hid/hid-lg4ff.c: avoid world-writable sysfs files.

2014-04-24 Thread Rusty Russell
madcatxs...@devoid-pointer.net writes: > On Thu Apr 24 2014 05:25:24 GMT+0200 (CEST), Rusty Russell wrote: >> si...@mungewell.org writes: >> >> si...@mungewell.org writes: >> >>> Yep I'm OK with that, however what it the recommended way to make sure >> >>> that the end user is able to send changes

Re: [PATCH 3/9] drivers/hid/hid-lg4ff.c: avoid world-writable sysfs files.

2014-04-24 Thread Rusty Russell
madcatxs...@devoid-pointer.net writes: On Thu Apr 24 2014 05:25:24 GMT+0200 (CEST), Rusty Russell wrote: si...@mungewell.org writes: si...@mungewell.org writes: Yep I'm OK with that, however what it the recommended way to make sure that the end user is able to send changes to this /sys

Re: [PATCH 3/9] drivers/hid/hid-lg4ff.c: avoid world-writable sysfs files.

2014-04-23 Thread Rusty Russell
si...@mungewell.org writes: >> si...@mungewell.org writes: >>> Yep I'm OK with that, however what it the recommended way to make sure >>> that the end user is able to send changes to this /sys portal? I asked >>> the >>> same question before regarding the led class /sys interface, but never >>>

Re: [PATCH 3/9] drivers/hid/hid-lg4ff.c: avoid world-writable sysfs files.

2014-04-23 Thread simon
> si...@mungewell.org writes: >>> In line with practice for module parameters, we're adding a build-time >>> check that sysfs files aren't world-writable. >> >> So this is the equivalent of 'chmod 774 ...' rather than 'chmod >> 777...'? > > Yep. Though not sure why it was 777 rather than 666... >

Re: [PATCH 3/9] drivers/hid/hid-lg4ff.c: avoid world-writable sysfs files.

2014-04-23 Thread Rusty Russell
si...@mungewell.org writes: si...@mungewell.org writes: Yep I'm OK with that, however what it the recommended way to make sure that the end user is able to send changes to this /sys portal? I asked the same question before regarding the led class /sys interface, but never got any

Re: [PATCH 3/9] drivers/hid/hid-lg4ff.c: avoid world-writable sysfs files.

2014-04-23 Thread simon
si...@mungewell.org writes: In line with practice for module parameters, we're adding a build-time check that sysfs files aren't world-writable. So this is the equivalent of 'chmod 774 ...' rather than 'chmod 777...'? Yep. Though not sure why it was 777 rather than 666... Yep I'm OK

Re: [PATCH 3/9] drivers/hid/hid-lg4ff.c: avoid world-writable sysfs files.

2014-04-22 Thread Rusty Russell
si...@mungewell.org writes: >> In line with practice for module parameters, we're adding a build-time >> check that sysfs files aren't world-writable. > > So this is the equivalent of 'chmod 774 ...' rather than 'chmod > 777...'? Yep. Though not sure why it was 777 rather than 666... > Yep I'm

Re: [PATCH 3/9] drivers/hid/hid-lg4ff.c: avoid world-writable sysfs files.

2014-04-22 Thread simon
> In line with practice for module parameters, we're adding a build-time > check that sysfs files aren't world-writable. So this is the equivalent of 'chmod 774 ...' rather than 'chmod 777...'? Yep I'm OK with that, however what it the recommended way to make sure that the end user is able to

Re: [PATCH 3/9] drivers/hid/hid-lg4ff.c: avoid world-writable sysfs files.

2014-04-22 Thread simon
In line with practice for module parameters, we're adding a build-time check that sysfs files aren't world-writable. So this is the equivalent of 'chmod 774 ...' rather than 'chmod 777...'? Yep I'm OK with that, however what it the recommended way to make sure that the end user is able to send

Re: [PATCH 3/9] drivers/hid/hid-lg4ff.c: avoid world-writable sysfs files.

2014-04-22 Thread Rusty Russell
si...@mungewell.org writes: In line with practice for module parameters, we're adding a build-time check that sysfs files aren't world-writable. So this is the equivalent of 'chmod 774 ...' rather than 'chmod 777...'? Yep. Though not sure why it was 777 rather than 666... Yep I'm OK with

[PATCH 3/9] drivers/hid/hid-lg4ff.c: avoid world-writable sysfs files.

2014-04-21 Thread Rusty Russell
In line with practice for module parameters, we're adding a build-time check that sysfs files aren't world-writable. Cc: Simon Wood Signed-off-by: Rusty Russell --- drivers/hid/hid-lg4ff.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hid/hid-lg4ff.c

[PATCH 3/9] drivers/hid/hid-lg4ff.c: avoid world-writable sysfs files.

2014-04-21 Thread Rusty Russell
In line with practice for module parameters, we're adding a build-time check that sysfs files aren't world-writable. Cc: Simon Wood si...@mungewell.org Signed-off-by: Rusty Russell ru...@rustcorp.com.au --- drivers/hid/hid-lg4ff.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git