Re: [PATCH 3/9] mm: remove seemingly spurious reclaimability check from laptop_mode gating

2017-03-01 Thread Hillf Danton
On March 01, 2017 5:40 AM Johannes Weiner wrote: > > 1d82de618ddd ("mm, vmscan: make kswapd reclaim in terms of nodes") > allowed laptop_mode=1 to start writing not just when the priority > drops to DEF_PRIORITY - 2 but also when the node is unreclaimable. > That appears to be a spurious change

Re: [PATCH 3/9] mm: remove seemingly spurious reclaimability check from laptop_mode gating

2017-03-01 Thread Hillf Danton
On March 01, 2017 5:40 AM Johannes Weiner wrote: > > 1d82de618ddd ("mm, vmscan: make kswapd reclaim in terms of nodes") > allowed laptop_mode=1 to start writing not just when the priority > drops to DEF_PRIORITY - 2 but also when the node is unreclaimable. > That appears to be a spurious change

Re: [PATCH 3/9] mm: remove seemingly spurious reclaimability check from laptop_mode gating

2017-03-01 Thread Michal Hocko
On Tue 28-02-17 16:40:01, Johannes Weiner wrote: > 1d82de618ddd ("mm, vmscan: make kswapd reclaim in terms of nodes") > allowed laptop_mode=1 to start writing not just when the priority > drops to DEF_PRIORITY - 2 but also when the node is unreclaimable. > That appears to be a spurious change in

Re: [PATCH 3/9] mm: remove seemingly spurious reclaimability check from laptop_mode gating

2017-03-01 Thread Michal Hocko
On Tue 28-02-17 16:40:01, Johannes Weiner wrote: > 1d82de618ddd ("mm, vmscan: make kswapd reclaim in terms of nodes") > allowed laptop_mode=1 to start writing not just when the priority > drops to DEF_PRIORITY - 2 but also when the node is unreclaimable. > That appears to be a spurious change in

Re: [PATCH 3/9] mm: remove seemingly spurious reclaimability check from laptop_mode gating

2017-03-01 Thread Mel Gorman
On Tue, Feb 28, 2017 at 04:40:01PM -0500, Johannes Weiner wrote: > 1d82de618ddd ("mm, vmscan: make kswapd reclaim in terms of nodes") > allowed laptop_mode=1 to start writing not just when the priority > drops to DEF_PRIORITY - 2 but also when the node is unreclaimable. > That appears to be a

Re: [PATCH 3/9] mm: remove seemingly spurious reclaimability check from laptop_mode gating

2017-03-01 Thread Mel Gorman
On Tue, Feb 28, 2017 at 04:40:01PM -0500, Johannes Weiner wrote: > 1d82de618ddd ("mm, vmscan: make kswapd reclaim in terms of nodes") > allowed laptop_mode=1 to start writing not just when the priority > drops to DEF_PRIORITY - 2 but also when the node is unreclaimable. > That appears to be a

[PATCH 3/9] mm: remove seemingly spurious reclaimability check from laptop_mode gating

2017-02-28 Thread Johannes Weiner
1d82de618ddd ("mm, vmscan: make kswapd reclaim in terms of nodes") allowed laptop_mode=1 to start writing not just when the priority drops to DEF_PRIORITY - 2 but also when the node is unreclaimable. That appears to be a spurious change in this patch as I doubt the series was tested with

[PATCH 3/9] mm: remove seemingly spurious reclaimability check from laptop_mode gating

2017-02-28 Thread Johannes Weiner
1d82de618ddd ("mm, vmscan: make kswapd reclaim in terms of nodes") allowed laptop_mode=1 to start writing not just when the priority drops to DEF_PRIORITY - 2 but also when the node is unreclaimable. That appears to be a spurious change in this patch as I doubt the series was tested with