Re: [PATCH 3/9] platform/x86: intel_pmc_core: Handle sub-states generically

2021-04-07 Thread Rajneesh Bhardwaj
A minor suggestion, num_modes should be called num_lpm_modes since it's a pmcdev's property. Acked-by: Rajneesh Bhardwaj On Wed, Mar 31, 2021 at 11:06 PM David E. Box wrote: > > From: Gayatri Kammela > > The current implementation of pmc_core_substate_res_show() is written > specifically for

Re: [PATCH 3/9] platform/x86: intel_pmc_core: Handle sub-states generically

2021-04-07 Thread Hans de Goede
Hi, On 4/1/21 5:05 AM, David E. Box wrote: > From: Gayatri Kammela > > The current implementation of pmc_core_substate_res_show() is written > specifically for Tiger Lake. However, new platforms will also have > sub-states and may support different modes. Therefore rewrite the code to > handle

[PATCH 3/9] platform/x86: intel_pmc_core: Handle sub-states generically

2021-03-31 Thread David E. Box
From: Gayatri Kammela The current implementation of pmc_core_substate_res_show() is written specifically for Tiger Lake. However, new platforms will also have sub-states and may support different modes. Therefore rewrite the code to handle sub-states generically. Read the number and type of