Re: [PATCH 3/9] regulator: core: Try full range when adjusting regulators to constraints

2016-08-23 Thread Mark Brown
On Tue, Aug 23, 2016 at 12:17:23PM +0800, Chen-Yu Tsai wrote: > On Tue, Aug 23, 2016 at 2:09 AM, Mark Brown wrote: > > Sure, but the constraints also say that you can do 1.32V which the > > system is not physically capable of delivering. That's not a good sign > > for the constraints, it suggest

Re: [PATCH 3/9] regulator: core: Try full range when adjusting regulators to constraints

2016-08-22 Thread Chen-Yu Tsai
On Tue, Aug 23, 2016 at 2:09 AM, Mark Brown wrote: > On Mon, Aug 22, 2016 at 07:52:05PM +0200, Rask Ingemann Lambertsen wrote: >> On Mon, Aug 22, 2016 at 05:29:07PM +0100, Mark Brown wrote: > >> > This seems like you have buggy constraints, constraints which allow >> > voltages that can't physical

Re: [PATCH 3/9] regulator: core: Try full range when adjusting regulators to constraints

2016-08-22 Thread Mark Brown
On Mon, Aug 22, 2016 at 07:52:05PM +0200, Rask Ingemann Lambertsen wrote: > On Mon, Aug 22, 2016 at 05:29:07PM +0100, Mark Brown wrote: > > This seems like you have buggy constraints, constraints which allow > > voltages that can't physically be satisfied don't make obvious sense. > No, it's for

Re: [PATCH 3/9] regulator: core: Try full range when adjusting regulators to constraints

2016-08-22 Thread Rask Ingemann Lambertsen
On Mon, Aug 22, 2016 at 05:29:07PM +0100, Mark Brown wrote: > On Sun, Aug 21, 2016 at 10:11:19AM +0800, Chen-Yu Tsai wrote: > > > Currently when we try to bring regulator in bounds of its constraints, > > we pick either the minimum or maximum voltage as the target. This fails > > if the regulator

Re: [PATCH 3/9] regulator: core: Try full range when adjusting regulators to constraints

2016-08-22 Thread Mark Brown
On Sun, Aug 21, 2016 at 10:11:19AM +0800, Chen-Yu Tsai wrote: > Currently when we try to bring regulator in bounds of its constraints, > we pick either the minimum or maximum voltage as the target. This fails > if the regulator range is not continuous, and the target voltage is not > an exact value

Re: [PATCH 3/9] regulator: core: Try full range when adjusting regulators to constraints

2016-08-22 Thread Mark Brown
On Sun, Aug 21, 2016 at 10:11:19AM +0800, Chen-Yu Tsai wrote: > Currently when we try to bring regulator in bounds of its constraints, > we pick either the minimum or maximum voltage as the target. This fails > if the regulator range is not continuous, and the target voltage is not > an exact valu

[PATCH 3/9] regulator: core: Try full range when adjusting regulators to constraints

2016-08-20 Thread Chen-Yu Tsai
Currently when we try to bring regulator in bounds of its constraints, we pick either the minimum or maximum voltage as the target. This fails if the regulator range is not continuous, and the target voltage is not an exact value the regulator can achieve, i.e. the target is not aligned to the step