Re: [PATCH 3/9] slab: move up code to get kmem_cache_node in free_block()

2014-02-16 Thread Joonsoo Kim
On Fri, Feb 14, 2014 at 03:19:02PM -0800, David Rientjes wrote: > On Fri, 14 Feb 2014, Joonsoo Kim wrote: > > > node isn't changed, so we don't need to retreive this structure > > everytime we move the object. Maybe compiler do this optimization, > > but making it explicitly is better. > > > >

Re: [PATCH 3/9] slab: move up code to get kmem_cache_node in free_block()

2014-02-16 Thread Joonsoo Kim
On Fri, Feb 14, 2014 at 03:19:02PM -0800, David Rientjes wrote: On Fri, 14 Feb 2014, Joonsoo Kim wrote: node isn't changed, so we don't need to retreive this structure everytime we move the object. Maybe compiler do this optimization, but making it explicitly is better. Would it be

Re: [PATCH 3/9] slab: move up code to get kmem_cache_node in free_block()

2014-02-14 Thread David Rientjes
On Fri, 14 Feb 2014, Joonsoo Kim wrote: > node isn't changed, so we don't need to retreive this structure > everytime we move the object. Maybe compiler do this optimization, > but making it explicitly is better. > Would it be possible to make it const struct kmem_cache_node *n then? -- To

Re: [PATCH 3/9] slab: move up code to get kmem_cache_node in free_block()

2014-02-14 Thread Christoph Lameter
On Fri, 14 Feb 2014, Joonsoo Kim wrote: > node isn't changed, so we don't need to retreive this structure > everytime we move the object. Maybe compiler do this optimization, > but making it explicitly is better. Acked-by: Christoph Lameter -- To unsubscribe from this list: send the line

Re: [PATCH 3/9] slab: move up code to get kmem_cache_node in free_block()

2014-02-14 Thread Christoph Lameter
On Fri, 14 Feb 2014, Joonsoo Kim wrote: node isn't changed, so we don't need to retreive this structure everytime we move the object. Maybe compiler do this optimization, but making it explicitly is better. Acked-by: Christoph Lameter c...@linux.com -- To unsubscribe from this list: send the

Re: [PATCH 3/9] slab: move up code to get kmem_cache_node in free_block()

2014-02-14 Thread David Rientjes
On Fri, 14 Feb 2014, Joonsoo Kim wrote: node isn't changed, so we don't need to retreive this structure everytime we move the object. Maybe compiler do this optimization, but making it explicitly is better. Would it be possible to make it const struct kmem_cache_node *n then? -- To

[PATCH 3/9] slab: move up code to get kmem_cache_node in free_block()

2014-02-13 Thread Joonsoo Kim
node isn't changed, so we don't need to retreive this structure everytime we move the object. Maybe compiler do this optimization, but making it explicitly is better. Signed-off-by: Joonsoo Kim diff --git a/mm/slab.c b/mm/slab.c index 6d17cad..53d1a36 100644 --- a/mm/slab.c +++ b/mm/slab.c @@

[PATCH 3/9] slab: move up code to get kmem_cache_node in free_block()

2014-02-13 Thread Joonsoo Kim
node isn't changed, so we don't need to retreive this structure everytime we move the object. Maybe compiler do this optimization, but making it explicitly is better. Signed-off-by: Joonsoo Kim iamjoonsoo@lge.com diff --git a/mm/slab.c b/mm/slab.c index 6d17cad..53d1a36 100644 ---