Re: [PATCH 3.10 219/268] tty/serial: atmel: fix race condition (TX+DMA)

2017-06-20 Thread Willy Tarreau
Hi Richard, On Tue, Jun 20, 2017 at 09:04:03AM +0200, Richard Genoud wrote: > Hi Willy, > > You can drop this patch. > > There's nothing to fix on 3.10.x since the DMA TX support has been > introduced in 3.12. I've already dropped it as it broke some build. Thanks! Willy

Re: [PATCH 3.10 219/268] tty/serial: atmel: fix race condition (TX+DMA)

2017-06-20 Thread Willy Tarreau
Hi Richard, On Tue, Jun 20, 2017 at 09:04:03AM +0200, Richard Genoud wrote: > Hi Willy, > > You can drop this patch. > > There's nothing to fix on 3.10.x since the DMA TX support has been > introduced in 3.12. I've already dropped it as it broke some build. Thanks! Willy

Re: [PATCH 3.10 219/268] tty/serial: atmel: fix race condition (TX+DMA)

2017-06-20 Thread Richard Genoud
Hi Willy, You can drop this patch. There's nothing to fix on 3.10.x since the DMA TX support has been introduced in 3.12. Thanks ! 2017-06-19 20:31 GMT+02:00 Willy Tarreau : > From: Richard Genoud > > commit 31ca2c63fdc0aee725cbd4f207c1256f5deaabde

Re: [PATCH 3.10 219/268] tty/serial: atmel: fix race condition (TX+DMA)

2017-06-20 Thread Richard Genoud
Hi Willy, You can drop this patch. There's nothing to fix on 3.10.x since the DMA TX support has been introduced in 3.12. Thanks ! 2017-06-19 20:31 GMT+02:00 Willy Tarreau : > From: Richard Genoud > > commit 31ca2c63fdc0aee725cbd4f207c1256f5deaabde upstream. > > If uart_flush_buffer() is

[PATCH 3.10 219/268] tty/serial: atmel: fix race condition (TX+DMA)

2017-06-19 Thread Willy Tarreau
From: Richard Genoud commit 31ca2c63fdc0aee725cbd4f207c1256f5deaabde upstream. If uart_flush_buffer() is called between atmel_tx_dma() and atmel_complete_tx_dma(), the circular buffer has been cleared, but not atmel_port->tx_len. That leads to a circular buffer

[PATCH 3.10 219/268] tty/serial: atmel: fix race condition (TX+DMA)

2017-06-19 Thread Willy Tarreau
From: Richard Genoud commit 31ca2c63fdc0aee725cbd4f207c1256f5deaabde upstream. If uart_flush_buffer() is called between atmel_tx_dma() and atmel_complete_tx_dma(), the circular buffer has been cleared, but not atmel_port->tx_len. That leads to a circular buffer overflow (dumping (UART_XMIT_SIZE