Re: [PATCH 3.12 69/76] net: fix infoleak in rtnetlink

2016-05-20 Thread Hannes Frederic Sowa
On 20.05.2016 18:45, David Miller wrote: > From: Vegard Nossum > Date: Fri, 20 May 2016 14:04:54 +0200 > >> Just out of curiosity, was this observed in practice? I could be >> wrong, but I was under the impression that using designated >> initializers would zero the rest of the struct, including

Re: [PATCH 3.12 69/76] net: fix infoleak in rtnetlink

2016-05-20 Thread David Miller
From: Vegard Nossum Date: Fri, 20 May 2016 14:04:54 +0200 > Just out of curiosity, was this observed in practice? I could be > wrong, but I was under the impression that using designated > initializers would zero the rest of the struct, including padding. I compiled testcases and found that the

Re: [PATCH 3.12 69/76] net: fix infoleak in rtnetlink

2016-05-20 Thread Vegard Nossum
On 20 May 2016 at 16:35, Kangjie Lu wrote: >> > Yes or no. According to my experiences, it depends on how >> > it is initialized: >> > if there are no variables but all constants in the bracket, >> > a global initializer will be generated, which will zero the remaining >> > bytes >> > including p

Re: [PATCH 3.12 69/76] net: fix infoleak in rtnetlink

2016-05-20 Thread Vegard Nossum
On 20 May 2016 at 15:43, Kangjie Lu wrote: > > > On Friday, May 20, 2016, Vegard Nossum wrote: >> >> On 19 May 2016 at 11:08, Jiri Slaby wrote: >> > From: Kangjie Lu >> > >> > 3.12-stable review patch. If anyone has any objections, please let me >> > know. >> > >> > === >> > >> > [

Re: [PATCH 3.12 69/76] net: fix infoleak in rtnetlink

2016-05-20 Thread Vegard Nossum
On 19 May 2016 at 11:08, Jiri Slaby wrote: > From: Kangjie Lu > > 3.12-stable review patch. If anyone has any objections, please let me know. > > === > > [ Upstream commit 5f8e44741f9f216e33736ea4ec65ca9ac03036e6 ] > > The stack object “map” has a total size of 32 bytes. Its last 4 >

[PATCH 3.12 69/76] net: fix infoleak in rtnetlink

2016-05-19 Thread Jiri Slaby
From: Kangjie Lu 3.12-stable review patch. If anyone has any objections, please let me know. === [ Upstream commit 5f8e44741f9f216e33736ea4ec65ca9ac03036e6 ] The stack object “map” has a total size of 32 bytes. Its last 4 bytes are padding generated by compiler. These padding byte