3.13-stable review patch. If anyone has any objections, please let me know.
------------------ From: Simon Wunderlich <s...@simonwunderlich.de> [ Upstream commit b2262df7fcf2c395eca564df83238e931d88d7bf ] Since batadv_orig_node_new() sets the refcount to two, assuming that the calling function will use a reference for putting the orig_node into a hash or similar, both references must be freed if initialization of the orig_node fails. Otherwise that object may be leaked in that error case. Reported-by: Antonio Quartulli <anto...@meshcoding.com> Signed-off-by: Simon Wunderlich <s...@simonwunderlich.de> Signed-off-by: Marek Lindner <mareklind...@neomailbox.ch> Signed-off-by: Antonio Quartulli <anto...@meshcoding.com> Signed-off-by: Greg Kroah-Hartman <gre...@linuxfoundation.org> --- net/batman-adv/bat_iv_ogm.c | 2 ++ 1 file changed, 2 insertions(+) --- a/net/batman-adv/bat_iv_ogm.c +++ b/net/batman-adv/bat_iv_ogm.c @@ -256,6 +256,8 @@ batadv_iv_ogm_orig_get(struct batadv_pri free_bcast_own: kfree(orig_node->bat_iv.bcast_own); free_orig_node: + /* free twice, as batadv_orig_node_new sets refcount to 2 */ + batadv_orig_node_free_ref(orig_node); batadv_orig_node_free_ref(orig_node); return NULL; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/