Re: [PATCH 3.18 104/105] IB/nes: Fix a compiler warning

2018-09-25 Thread Joe Perches
On Tue, 2018-09-25 at 13:32 +0200, Greg Kroah-Hartman wrote: > On Tue, Sep 25, 2018 at 04:11:38AM -0700, Joe Perches wrote: > > On Tue, 2018-09-25 at 10:55 +0200, Greg Kroah-Hartman wrote: [] > > > No warnings is great, > > > > I believe that is not necessarily true. > > For me, it is essencial.

Re: [PATCH 3.18 104/105] IB/nes: Fix a compiler warning

2018-09-25 Thread Greg Kroah-Hartman
On Tue, Sep 25, 2018 at 04:11:38AM -0700, Joe Perches wrote: > On Tue, 2018-09-25 at 10:55 +0200, Greg Kroah-Hartman wrote: > > On Mon, Sep 24, 2018 at 10:39:53PM +, Sasha Levin wrote: > > > On Mon, Sep 24, 2018 at 11:03:25AM -0700, Joe Perches wrote: > > > > On Mon, 2018-09-24 at 19:59 +0200,

Re: [PATCH 3.18 104/105] IB/nes: Fix a compiler warning

2018-09-25 Thread Joe Perches
On Tue, 2018-09-25 at 10:55 +0200, Greg Kroah-Hartman wrote: > On Mon, Sep 24, 2018 at 10:39:53PM +, Sasha Levin wrote: > > On Mon, Sep 24, 2018 at 11:03:25AM -0700, Joe Perches wrote: > > > On Mon, 2018-09-24 at 19:59 +0200, Greg Kroah-Hartman wrote: > > > > On Mon, Sep 24, 2018 at 09:38:26AM

Re: [PATCH 3.18 104/105] IB/nes: Fix a compiler warning

2018-09-25 Thread Greg Kroah-Hartman
On Mon, Sep 24, 2018 at 10:39:53PM +, Sasha Levin wrote: > On Mon, Sep 24, 2018 at 11:03:25AM -0700, Joe Perches wrote: > >On Mon, 2018-09-24 at 19:59 +0200, Greg Kroah-Hartman wrote: > >> On Mon, Sep 24, 2018 at 09:38:26AM -0700, Joe Perches wrote: > >> > On Mon, 2018-09-24 at 13:34 +0200, Gre

Re: [PATCH 3.18 104/105] IB/nes: Fix a compiler warning

2018-09-24 Thread Joe Perches
On Mon, 2018-09-24 at 22:39 +, Sasha Levin wrote: > The reasoning behind it was similar to the "no warnings" reasoning of > upstream: there might be real issues hiding in the sea of "harmless" > warnings, so we want to get rid of all of them to catch real issues. I believe this to be a poor id

Re: [PATCH 3.18 104/105] IB/nes: Fix a compiler warning

2018-09-24 Thread Sasha Levin
On Mon, Sep 24, 2018 at 11:03:25AM -0700, Joe Perches wrote: >On Mon, 2018-09-24 at 19:59 +0200, Greg Kroah-Hartman wrote: >> On Mon, Sep 24, 2018 at 09:38:26AM -0700, Joe Perches wrote: >> > On Mon, 2018-09-24 at 13:34 +0200, Greg Kroah-Hartman wrote: >> > > 3.18-stable review patch. If anyone ha

Re: [PATCH 3.18 104/105] IB/nes: Fix a compiler warning

2018-09-24 Thread Greg Kroah-Hartman
On Mon, Sep 24, 2018 at 11:03:25AM -0700, Joe Perches wrote: > On Mon, 2018-09-24 at 19:59 +0200, Greg Kroah-Hartman wrote: > > On Mon, Sep 24, 2018 at 09:38:26AM -0700, Joe Perches wrote: > > > On Mon, 2018-09-24 at 13:34 +0200, Greg Kroah-Hartman wrote: > > > > 3.18-stable review patch. If anyon

Re: [PATCH 3.18 104/105] IB/nes: Fix a compiler warning

2018-09-24 Thread Joe Perches
On Mon, 2018-09-24 at 19:59 +0200, Greg Kroah-Hartman wrote: > On Mon, Sep 24, 2018 at 09:38:26AM -0700, Joe Perches wrote: > > On Mon, 2018-09-24 at 13:34 +0200, Greg Kroah-Hartman wrote: > > > 3.18-stable review patch. If anyone has any objections, please let me > > > know. > > > > Why should

Re: [PATCH 3.18 104/105] IB/nes: Fix a compiler warning

2018-09-24 Thread Greg Kroah-Hartman
On Mon, Sep 24, 2018 at 09:38:26AM -0700, Joe Perches wrote: > On Mon, 2018-09-24 at 13:34 +0200, Greg Kroah-Hartman wrote: > > 3.18-stable review patch. If anyone has any objections, please let me know. > > Why should this sort of change be applied to a stable release? Originally I was just goi

Re: [PATCH 3.18 104/105] IB/nes: Fix a compiler warning

2018-09-24 Thread Joe Perches
On Mon, 2018-09-24 at 13:34 +0200, Greg Kroah-Hartman wrote: > 3.18-stable review patch. If anyone has any objections, please let me know. Why should this sort of change be applied to a stable release? > -- > > From: Bart Van Assche > > [ Upstream commit 4c5743bc4fe3233cecc1c1

[PATCH 3.18 104/105] IB/nes: Fix a compiler warning

2018-09-24 Thread Greg Kroah-Hartman
3.18-stable review patch. If anyone has any objections, please let me know. -- From: Bart Van Assche [ Upstream commit 4c5743bc4fe3233cecc1c184a773c79c8ee45bbe ] Avoid that the following compiler warning is reported when building with W=1: drivers/infiniband/hw/nes/nes_hw.c:6