Re: [PATCH 3.18 11/61] workqueue: fix subtle pool management issue which can stall whole worker_pool

2015-02-02 Thread Luis Henriques
On Thu, Jan 29, 2015 at 03:33:25PM -0500, Tejun Heo wrote: > Hello, > > On Wed, Jan 28, 2015 at 09:54:48AM -0800, Greg Kroah-Hartman wrote: > > This patch will apply to 3.10, but not 3.14, and I'm confused. Should I > > backport the original version to 3.14? 3.10? Use this different > > version

Re: [PATCH 3.18 11/61] workqueue: fix subtle pool management issue which can stall whole worker_pool

2015-01-29 Thread Tejun Heo
Hello, On Wed, Jan 28, 2015 at 09:54:48AM -0800, Greg Kroah-Hartman wrote: > This patch will apply to 3.10, but not 3.14, and I'm confused. Should I > backport the original version to 3.14? 3.10? Use this different > version instead? The original version should apply fine back to 3.16. Before

Re: [PATCH 3.18 11/61] workqueue: fix subtle pool management issue which can stall whole worker_pool

2015-01-28 Thread Greg Kroah-Hartman
On Wed, Jan 28, 2015 at 10:07:01AM -0500, Tejun Heo wrote: > On Wed, Jan 28, 2015 at 11:15:32AM +0800, Lai Jiangshan wrote: > > Was the bug introduced at the first time when maybe_create_worker() was > > introduced? Although manage_workers()/maybe_create_worker() was changed a > > bit, > > the st

Re: [PATCH 3.18 11/61] workqueue: fix subtle pool management issue which can stall whole worker_pool

2015-01-28 Thread Tejun Heo
On Wed, Jan 28, 2015 at 11:15:32AM +0800, Lai Jiangshan wrote: > Was the bug introduced at the first time when maybe_create_worker() was > introduced? Although manage_workers()/maybe_create_worker() was changed a > bit, > the stable-tree team can simply make manage_workers() return true to fix >

Re: [PATCH 3.18 11/61] workqueue: fix subtle pool management issue which can stall whole worker_pool

2015-01-27 Thread Lai Jiangshan
On 01/28/2015 10:24 AM, Tejun Heo wrote: > On Wed, Jan 28, 2015 at 09:51:54AM +0800, Lai Jiangshan wrote: >> On 01/28/2015 09:26 AM, Greg Kroah-Hartman wrote: >>> 3.18-stable review patch. If anyone has any objections, please let me know. >> >> >> I don't think it is a bug-fix. >> It is just a goo

Re: [PATCH 3.18 11/61] workqueue: fix subtle pool management issue which can stall whole worker_pool

2015-01-27 Thread Tejun Heo
On Wed, Jan 28, 2015 at 09:51:54AM +0800, Lai Jiangshan wrote: > On 01/28/2015 09:26 AM, Greg Kroah-Hartman wrote: > > 3.18-stable review patch. If anyone has any objections, please let me know. > > > I don't think it is a bug-fix. > It is just a good cleanup. It is a bug fix, for a rare but po

[PATCH 3.18 11/61] workqueue: fix subtle pool management issue which can stall whole worker_pool

2015-01-27 Thread Greg Kroah-Hartman
3.18-stable review patch. If anyone has any objections, please let me know. -- From: Tejun Heo commit 29187a9eeaf362d8422e62e17a22a6e115277a49 upstream. A worker_pool's forward progress is guaranteed by the fact that the last idle worker assumes the manager role to create more

Re: [PATCH 3.18 11/61] workqueue: fix subtle pool management issue which can stall whole worker_pool

2015-01-27 Thread Lai Jiangshan
On 01/28/2015 09:26 AM, Greg Kroah-Hartman wrote: > 3.18-stable review patch. If anyone has any objections, please let me know. I don't think it is a bug-fix. It is just a good cleanup. > > -- > > From: Tejun Heo > > commit 29187a9eeaf362d8422e62e17a22a6e115277a49 upstream.