Re: [PATCH 3.18 78/86] bridge: Fix error path for kobject_init_and_add()

2019-05-15 Thread Greg Kroah-Hartman
On Thu, May 16, 2019 at 06:48:40AM +1000, Tobin C. Harding wrote: > On Wed, May 15, 2019 at 12:55:55PM +0200, Greg Kroah-Hartman wrote: > > From: "Tobin C. Harding" > > > > [ Upstream commit bdfad5aec1392b93495b77b864d58d7f101dc1c1 ] > > Greg you are not going to back port all of these kobject

Re: [PATCH 3.18 78/86] bridge: Fix error path for kobject_init_and_add()

2019-05-15 Thread Tobin C. Harding
On Wed, May 15, 2019 at 12:55:55PM +0200, Greg Kroah-Hartman wrote: > From: "Tobin C. Harding" > > [ Upstream commit bdfad5aec1392b93495b77b864d58d7f101dc1c1 ] Greg you are not going to back port all of these kobject fixes are you? There is going to be a _lot_ of them. I'm not super

[PATCH 3.18 78/86] bridge: Fix error path for kobject_init_and_add()

2019-05-15 Thread Greg Kroah-Hartman
From: "Tobin C. Harding" [ Upstream commit bdfad5aec1392b93495b77b864d58d7f101dc1c1 ] Currently error return from kobject_init_and_add() is not followed by a call to kobject_put(). This means there is a memory leak. We currently set p to NULL so that kfree() may be called on it as a noop, the