Re: [PATCH 3.19 v2 1/3] x86: Fix off-by-one in the instruction decoder length checks

2015-01-12 Thread Andy Lutomirski
On Mon, Jan 12, 2015 at 3:13 PM, Dave Hansen wrote: > On 01/12/2015 03:04 PM, Andy Lutomirski wrote: >> diff --git a/arch/x86/lib/insn.c b/arch/x86/lib/insn.c >> index 2480978b31cc..1313ae6b478b 100644 >> --- a/arch/x86/lib/insn.c >> +++ b/arch/x86/lib/insn.c >> @@ -28,7 +28,7 @@ >> >> /* Verify

Re: [PATCH 3.19 v2 1/3] x86: Fix off-by-one in the instruction decoder length checks

2015-01-12 Thread Dave Hansen
On 01/12/2015 03:04 PM, Andy Lutomirski wrote: > diff --git a/arch/x86/lib/insn.c b/arch/x86/lib/insn.c > index 2480978b31cc..1313ae6b478b 100644 > --- a/arch/x86/lib/insn.c > +++ b/arch/x86/lib/insn.c > @@ -28,7 +28,7 @@ > > /* Verify next sizeof(t) bytes can be on the same instruction */ >

[PATCH 3.19 v2 1/3] x86: Fix off-by-one in the instruction decoder length checks

2015-01-12 Thread Andy Lutomirski
If next_byte + sizeof(t) == end_kaddr, then we are trying to read exactly to the end; this should be allowed. Fixes: 6ba48ff46f76 x86: Remove arbitrary instruction size limit in instruction decoder Signed-off-by: Andy Lutomirski --- arch/x86/lib/insn.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH 3.19 v2 1/3] x86: Fix off-by-one in the instruction decoder length checks

2015-01-12 Thread Andy Lutomirski
If next_byte + sizeof(t) == end_kaddr, then we are trying to read exactly to the end; this should be allowed. Fixes: 6ba48ff46f76 x86: Remove arbitrary instruction size limit in instruction decoder Signed-off-by: Andy Lutomirski l...@amacapital.net --- arch/x86/lib/insn.c | 2 +- 1 file

Re: [PATCH 3.19 v2 1/3] x86: Fix off-by-one in the instruction decoder length checks

2015-01-12 Thread Dave Hansen
On 01/12/2015 03:04 PM, Andy Lutomirski wrote: diff --git a/arch/x86/lib/insn.c b/arch/x86/lib/insn.c index 2480978b31cc..1313ae6b478b 100644 --- a/arch/x86/lib/insn.c +++ b/arch/x86/lib/insn.c @@ -28,7 +28,7 @@ /* Verify next sizeof(t) bytes can be on the same instruction */ #define

Re: [PATCH 3.19 v2 1/3] x86: Fix off-by-one in the instruction decoder length checks

2015-01-12 Thread Andy Lutomirski
On Mon, Jan 12, 2015 at 3:13 PM, Dave Hansen dave.han...@linux.intel.com wrote: On 01/12/2015 03:04 PM, Andy Lutomirski wrote: diff --git a/arch/x86/lib/insn.c b/arch/x86/lib/insn.c index 2480978b31cc..1313ae6b478b 100644 --- a/arch/x86/lib/insn.c +++ b/arch/x86/lib/insn.c @@ -28,7 +28,7 @@