Re: [PATCH 3.2 091/102] KVM: x86: Emulator fixes for eip canonical checks on near branches

2014-11-03 Thread Ben Hutchings
On Sun, 2014-11-02 at 10:44 +0200, Nadav Amit wrote: > Sorry, but this patch is incomplete due to a bug. > The following patch - http://www.spinics.net/lists/kvm/msg109664.html - is > needed as well (on top of the previous one). Thanks, I've added that (commit 7e466f6c). Ben. > Nadav > > >

Re: [PATCH 3.2 091/102] KVM: x86: Emulator fixes for eip canonical checks on near branches

2014-11-02 Thread Nadav Amit
Sorry, but this patch is incomplete due to a bug. The following patch - http://www.spinics.net/lists/kvm/msg109664.html - is needed as well (on top of the previous one). Nadav > On Nov 2, 2014, at 00:28, Ben Hutchings wrote: > > 3.2.64-rc1 review patch. If anyone has any objections, please le

[PATCH 3.2 091/102] KVM: x86: Emulator fixes for eip canonical checks on near branches

2014-11-01 Thread Ben Hutchings
3.2.64-rc1 review patch. If anyone has any objections, please let me know. -- From: Nadav Amit commit 234f3ce485d54017f15cf5e0699cff4100121601 upstream. Before changing rip (during jmp, call, ret, etc.) the target should be asserted to be canonical one, as real CPUs do. Durin