Re: [PATCH 3.2 63/87] ext4: fix memory leak in xattr

2013-11-25 Thread Ben Hutchings
On Mon, 2013-11-25 at 14:02 -0500, Dave Jones wrote: > On Mon, Nov 25, 2013 at 01:44:29PM +, Ben Hutchings wrote: > > 3.2.53-rc1 review patch. If anyone has any objections, please let me know. > > > > --- a/fs/ext4/xattr.c > > +++ b/fs/ext4/xattr.c > > @@ -1269,6 +1269,8 @@ retry: > >

Re: [PATCH 3.2 63/87] ext4: fix memory leak in xattr

2013-11-25 Thread Dave Jones
On Mon, Nov 25, 2013 at 01:44:29PM +, Ben Hutchings wrote: > 3.2.53-rc1 review patch. If anyone has any objections, please let me know. > > --- a/fs/ext4/xattr.c > +++ b/fs/ext4/xattr.c > @@ -1269,6 +1269,8 @@ retry: > s_min_extra_isize) { >

[PATCH 3.2 63/87] ext4: fix memory leak in xattr

2013-11-25 Thread Ben Hutchings
3.2.53-rc1 review patch. If anyone has any objections, please let me know. -- From: Dave Jones commit 6e4ea8e33b2057b85d75175dd89b93f5e26de3bc upstream. If we take the 2nd retry path in ext4_expand_extra_isize_ea, we potentionally return from the function without having freed

[PATCH 3.2 63/87] ext4: fix memory leak in xattr

2013-11-25 Thread Ben Hutchings
3.2.53-rc1 review patch. If anyone has any objections, please let me know. -- From: Dave Jones da...@redhat.com commit 6e4ea8e33b2057b85d75175dd89b93f5e26de3bc upstream. If we take the 2nd retry path in ext4_expand_extra_isize_ea, we potentionally return from the function

Re: [PATCH 3.2 63/87] ext4: fix memory leak in xattr

2013-11-25 Thread Dave Jones
On Mon, Nov 25, 2013 at 01:44:29PM +, Ben Hutchings wrote: 3.2.53-rc1 review patch. If anyone has any objections, please let me know. --- a/fs/ext4/xattr.c +++ b/fs/ext4/xattr.c @@ -1269,6 +1269,8 @@ retry: s_min_extra_isize) {

Re: [PATCH 3.2 63/87] ext4: fix memory leak in xattr

2013-11-25 Thread Ben Hutchings
On Mon, 2013-11-25 at 14:02 -0500, Dave Jones wrote: On Mon, Nov 25, 2013 at 01:44:29PM +, Ben Hutchings wrote: 3.2.53-rc1 review patch. If anyone has any objections, please let me know. --- a/fs/ext4/xattr.c +++ b/fs/ext4/xattr.c @@ -1269,6 +1269,8 @@ retry: