Re: [PATCH 3.6 1/2] target: remove pscsi_clear_cdb_lun

2012-09-07 Thread Nicholas A. Bellinger
On Fri, 2012-09-07 at 13:51 +0200, Paolo Bonzini wrote: > Il 07/09/2012 05:22, Nicholas A. Bellinger ha scritto: > > Care to respin..? ;) > > Sure, but I suppose this will be 3.7 material. > Do you want an attribute too? > M, still undecided on that one. I'd really like to avoid adding

Re: [PATCH 3.6 1/2] target: remove pscsi_clear_cdb_lun

2012-09-07 Thread Paolo Bonzini
Il 07/09/2012 05:22, Nicholas A. Bellinger ha scritto: > Care to respin..? ;) Sure, but I suppose this will be 3.7 material. Do you want an attribute too? Paolo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More

Re: [PATCH 3.6 1/2] target: remove pscsi_clear_cdb_lun

2012-09-06 Thread Nicholas A. Bellinger
On Thu, 2012-09-06 at 22:51 +0200, Paolo Bonzini wrote: > Il 06/09/2012 20:58, Nicholas A. Bellinger ha scritto: > > On Thu, 2012-09-06 at 17:13 +0200, Paolo Bonzini wrote: > >> The purpose of this function is to clear a LUN set in the CDB, in case > >> the initiator talking to us is speaking an ol

Re: [PATCH 3.6 1/2] target: remove pscsi_clear_cdb_lun

2012-09-06 Thread Paolo Bonzini
Il 06/09/2012 20:58, Nicholas A. Bellinger ha scritto: > On Thu, 2012-09-06 at 17:13 +0200, Paolo Bonzini wrote: >> The purpose of this function is to clear a LUN set in the CDB, in case >> the initiator talking to us is speaking an old standards version. >> However, as things stand, pscsi_clear_cd

Re: [PATCH 3.6 1/2] target: remove pscsi_clear_cdb_lun

2012-09-06 Thread Nicholas A. Bellinger
On Thu, 2012-09-06 at 17:13 +0200, Paolo Bonzini wrote: > The purpose of this function is to clear a LUN set in the CDB, in case > the initiator talking to us is speaking an old standards version. > However, as things stand, pscsi_clear_cdb_lun has two problems. It > will "deceive" the guest by cl

[PATCH 3.6 1/2] target: remove pscsi_clear_cdb_lun

2012-09-06 Thread Paolo Bonzini
The purpose of this function is to clear a LUN set in the CDB, in case the initiator talking to us is speaking an old standards version. However, as things stand, pscsi_clear_cdb_lun has two problems. It will "deceive" the guest by clearing the LUN bits on initial commands (INQUIRY, TEST UNIT READ