Re: [PATCH 30/30] PCI: remove pci_get_bus_and_slot() function

2017-11-22 Thread Sinan Kaya
On 11/22/2017 9:49 AM, Greg KH wrote: >>> If you have out-of-tree drivers, then yes, they can make a wrapper for >>> this function like this if they really feel the need, or they can get >>> their code merged:) >> Sorry, I guess I should have been clearer. My suggestion was to fix some of >> the d

Re: [PATCH 30/30] PCI: remove pci_get_bus_and_slot() function

2017-11-22 Thread Greg KH
On Wed, Nov 22, 2017 at 08:42:35AM -0600, Timur Tabi wrote: > On 11/22/17 1:51 AM, Greg KH wrote: > > Ick, no, why? What is wrong with removing this function as is? Don't > > mark something as __depreciated if there are no in-kernel users, just > > delete it and move on. > > > > If you have out-

Re: [PATCH 30/30] PCI: remove pci_get_bus_and_slot() function

2017-11-22 Thread Timur Tabi
On 11/22/17 1:51 AM, Greg KH wrote: Ick, no, why? What is wrong with removing this function as is? Don't mark something as __depreciated if there are no in-kernel users, just delete it and move on. If you have out-of-tree drivers, then yes, they can make a wrapper for this function like this i

Re: [PATCH 30/30] PCI: remove pci_get_bus_and_slot() function

2017-11-21 Thread Greg KH
On Wed, Nov 22, 2017 at 12:08:45AM -0600, Timur Tabi wrote: > On 11/21/17 11:55 PM, Sinan Kaya wrote: > > For places where domain number information is available, I extracted domain > > number > > and added into pci_get_domain_bus_and_slot() call such as xen or bn drivers. > > My suggestion is th

Re: [PATCH 30/30] PCI: remove pci_get_bus_and_slot() function

2017-11-21 Thread Timur Tabi
On 11/21/17 11:55 PM, Sinan Kaya wrote: For places where domain number information is available, I extracted domain number and added into pci_get_domain_bus_and_slot() call such as xen or bn drivers. My suggestion is that you restrict your first patch set to only these patches. The assumpt

Re: [PATCH 30/30] PCI: remove pci_get_bus_and_slot() function

2017-11-21 Thread Sinan Kaya
On 11/22/2017 12:45 AM, Timur Tabi wrote: > On 11/21/17 11:31 PM, Sinan Kaya wrote: >> Use pci_get_domain_bus_and_slot() with a domain number of 0 where we can't >> extract the domain number. Other places, use the actual domain number from >> the device. >> >> Now that all users of pci_get_bus_and_

Re: [PATCH 30/30] PCI: remove pci_get_bus_and_slot() function

2017-11-21 Thread Timur Tabi
On 11/21/17 11:31 PM, Sinan Kaya wrote: Use pci_get_domain_bus_and_slot() with a domain number of 0 where we can't extract the domain number. Other places, use the actual domain number from the device. Now that all users of pci_get_bus_and_slot() switched to pci_get_domain_bus_and_slot(), it is

[PATCH 30/30] PCI: remove pci_get_bus_and_slot() function

2017-11-21 Thread Sinan Kaya
pci_get_bus_and_slot() is restrictive such that it assumes domain=0 as where a PCI device is present. This restricts the device drivers to be reused for other domain numbers. Use pci_get_domain_bus_and_slot() with a domain number of 0 where we can't extract the domain number. Other places, use the