Re: [PATCH 31/31] timer: Switch to testing for .function instead of .data

2017-09-02 Thread Rafael J. Wysocki
On Friday, September 1, 2017 1:29:43 AM CEST Kees Cook wrote: > In several places, .data is checked for initialization to gate early > calls to del_timer_sync(). Checking for .function is equally valid, so > switch to this in all callers. > > Cc: "Rafael J. Wysocki" > Cc: Pavel Machek > Cc: Len

Re: [PATCH 31/31] timer: Switch to testing for .function instead of .data

2017-09-01 Thread Jeff Kirsher
On Thu, 2017-08-31 at 16:29 -0700, Kees Cook wrote: > In several places, .data is checked for initialization to gate early > calls to del_timer_sync(). Checking for .function is equally valid, > so > switch to this in all callers. > > Cc: "Rafael J. Wysocki" > Cc: Pavel Machek > Cc: Len Brown >

Re: [PATCH 31/31] timer: Switch to testing for .function instead of .data

2017-08-31 Thread Dmitry Torokhov
On Thu, Aug 31, 2017 at 4:59 PM, Kees Cook wrote: > On Thu, Aug 31, 2017 at 4:45 PM, Dmitry Torokhov > wrote: >> On Thu, Aug 31, 2017 at 4:29 PM, Kees Cook wrote: >>> In several places, .data is checked for initialization to gate early >>> calls to del_timer_sync(). Checking for .function is equ

Re: [PATCH 31/31] timer: Switch to testing for .function instead of .data

2017-08-31 Thread Kees Cook
On Thu, Aug 31, 2017 at 4:45 PM, Dmitry Torokhov wrote: > On Thu, Aug 31, 2017 at 4:29 PM, Kees Cook wrote: >> In several places, .data is checked for initialization to gate early >> calls to del_timer_sync(). Checking for .function is equally valid, so >> switch to this in all callers. > > Not s

Re: [PATCH 31/31] timer: Switch to testing for .function instead of .data

2017-08-31 Thread Dmitry Torokhov
On Thu, Aug 31, 2017 at 4:29 PM, Kees Cook wrote: > In several places, .data is checked for initialization to gate early > calls to del_timer_sync(). Checking for .function is equally valid, so > switch to this in all callers. Not seeing the rest of patches it is unclear from the patch descriptio

[PATCH 31/31] timer: Switch to testing for .function instead of .data

2017-08-31 Thread Kees Cook
In several places, .data is checked for initialization to gate early calls to del_timer_sync(). Checking for .function is equally valid, so switch to this in all callers. Cc: "Rafael J. Wysocki" Cc: Pavel Machek Cc: Len Brown Cc: Greg Kroah-Hartman Cc: Mike Marciniszyn Cc: Dennis Dalessandro