Re: [PATCH 33/36] autonuma: powerpc port

2012-08-23 Thread Benjamin Herrenschmidt
On Thu, 2012-08-23 at 15:11 +1000, Benjamin Herrenschmidt wrote: > So we don't do protnone, and now that you mention it, I think that > means > that some of our embedded stuff is busted :-) > > Basically PROT_NONE turns into _PAGE_PRESENT without _PAGE_USER for > us. .../... > Looks like the S

Re: [PATCH 33/36] autonuma: powerpc port

2012-08-23 Thread Andrea Arcangeli
Hi Benjamin, On Thu, Aug 23, 2012 at 03:11:00PM +1000, Benjamin Herrenschmidt wrote: > Basically PROT_NONE turns into _PAGE_PRESENT without _PAGE_USER for us. Maybe the simplest is to implement pte_numa as !_PAGE_USER too. No need to clear the _PAGE_PRESENT bit and to alter pte_present() if clear

Re: [PATCH 33/36] autonuma: powerpc port

2012-08-22 Thread Benjamin Herrenschmidt
On Thu, 2012-08-23 at 00:35 +0200, Andrea Arcangeli wrote: > I'm actually surprised you don't already check for PROTNONE > there. Anyway yes this is necessary, the whole concept of NUMA hinting > page faults is to make the pte not present, and to set another bit (be > it a reserved bit or PROTNONE

Re: [PATCH 33/36] autonuma: powerpc port

2012-08-22 Thread Vaidyanathan Srinivasan
* Benjamin Herrenschmidt [2012-08-23 08:56:34]: > On Thu, 2012-08-23 at 08:01 +1000, Benjamin Herrenschmidt wrote: > > On Wed, 2012-08-22 at 16:59 +0200, Andrea Arcangeli wrote: > > > From: Vaidyanathan Srinivasan > > > > > > * PMD flaging is not required in powerpc since large pages > > >

Re: [PATCH 33/36] autonuma: powerpc port

2012-08-22 Thread Andrea Arcangeli
Hi Benjamin, On Thu, Aug 23, 2012 at 08:56:34AM +1000, Benjamin Herrenschmidt wrote: > What I mean here is that it's fine as a proof of concept ;-) I don't > like it being in a series aimed at upstream... > > We can try to flush out the issues, but as it is, the patch isn't > upstreamable imho.

Re: [PATCH 33/36] autonuma: powerpc port

2012-08-22 Thread Benjamin Herrenschmidt
On Thu, 2012-08-23 at 08:01 +1000, Benjamin Herrenschmidt wrote: > On Wed, 2012-08-22 at 16:59 +0200, Andrea Arcangeli wrote: > > From: Vaidyanathan Srinivasan > > > > * PMD flaging is not required in powerpc since large pages > > are tracked in ptes. > > * Yet to be tested with lar

Re: [PATCH 33/36] autonuma: powerpc port

2012-08-22 Thread Andrea Arcangeli
On Thu, Aug 23, 2012 at 08:01:47AM +1000, Benjamin Herrenschmidt wrote: > On Wed, 2012-08-22 at 16:59 +0200, Andrea Arcangeli wrote: > > diff --git a/arch/powerpc/include/asm/pgtable.h > > b/arch/powerpc/include/asm/pgtable.h > > index 2e0e411..5f03079 100644 > > --- a/arch/powerpc/include/asm/pgt

Re: [PATCH 33/36] autonuma: powerpc port

2012-08-22 Thread Benjamin Herrenschmidt
On Wed, 2012-08-22 at 16:59 +0200, Andrea Arcangeli wrote: > From: Vaidyanathan Srinivasan > > * PMD flaging is not required in powerpc since large pages > are tracked in ptes. > * Yet to be tested with large pages > * This is an initial patch that partially works > * knuma_

[PATCH 33/36] autonuma: powerpc port

2012-08-22 Thread Andrea Arcangeli
From: Vaidyanathan Srinivasan * PMD flaging is not required in powerpc since large pages are tracked in ptes. * Yet to be tested with large pages * This is an initial patch that partially works * knuma_scand and numa hinting page faults works * Page migration is yet to b