Re: [PATCH 33/49] ext4: Add the journal checksum feature

2008-02-01 Thread Girish Shilamkar
Hi, On Thu, 2008-01-24 at 13:24 -0800, Mingming Cao wrote: > -static int journal_write_commit_record(journal_t *journal, > - transaction_t *commit_transaction) > +static int journal_submit_commit_record(journal_t *journal, > +

Re: [PATCH 33/49] ext4: Add the journal checksum feature

2008-02-01 Thread Girish Shilamkar
Hi, On Thu, 2008-01-24 at 13:24 -0800, Mingming Cao wrote: -static int journal_write_commit_record(journal_t *journal, - transaction_t *commit_transaction) +static int journal_submit_commit_record(journal_t *journal, +

Re: [PATCH 33/49] ext4: Add the journal checksum feature

2008-01-24 Thread Mingming Cao
On Wed, 2008-01-23 at 14:07 -0800, Andrew Morton wrote: > > On Mon, 21 Jan 2008 22:02:12 -0500 "Theodore Ts'o" <[EMAIL PROTECTED]> > > wrote: > > From: Girish Shilamkar <[EMAIL PROTECTED]> > > > > The journal checksum feature adds two new flags i.e > > JBD2_FEATURE_INCOMPAT_ASYNC_COMMIT and

Re: [PATCH 33/49] ext4: Add the journal checksum feature

2008-01-24 Thread Mingming Cao
On Wed, 2008-01-23 at 14:07 -0800, Andrew Morton wrote: On Mon, 21 Jan 2008 22:02:12 -0500 Theodore Ts'o [EMAIL PROTECTED] wrote: From: Girish Shilamkar [EMAIL PROTECTED] The journal checksum feature adds two new flags i.e JBD2_FEATURE_INCOMPAT_ASYNC_COMMIT and

Re: [PATCH 33/49] ext4: Add the journal checksum feature

2008-01-23 Thread Andreas Dilger
On Jan 23, 2008 14:07 -0800, Andrew Morton wrote: > > +{ > > + struct page *page = bh->b_page; > > + char *addr; > > + __u32 checksum; > > + > > + addr = kmap_atomic(page, KM_USER0); > > + checksum = crc32_be(crc32_sum, > > + (void *)(addr + offset_in_page(bh->b_data)),

Re: [PATCH 33/49] ext4: Add the journal checksum feature

2008-01-23 Thread Andrew Morton
> On Mon, 21 Jan 2008 22:02:12 -0500 "Theodore Ts'o" <[EMAIL PROTECTED]> wrote: > From: Girish Shilamkar <[EMAIL PROTECTED]> > > The journal checksum feature adds two new flags i.e > JBD2_FEATURE_INCOMPAT_ASYNC_COMMIT and JBD2_FEATURE_COMPAT_CHECKSUM. > > JBD2_FEATURE_CHECKSUM flag indicates

Re: [PATCH 33/49] ext4: Add the journal checksum feature

2008-01-23 Thread Andreas Dilger
On Jan 23, 2008 14:07 -0800, Andrew Morton wrote: +{ + struct page *page = bh-b_page; + char *addr; + __u32 checksum; + + addr = kmap_atomic(page, KM_USER0); + checksum = crc32_be(crc32_sum, + (void *)(addr + offset_in_page(bh-b_data)), bh-b_size); +

[PATCH 33/49] ext4: Add the journal checksum feature

2008-01-21 Thread Theodore Ts'o
From: Girish Shilamkar <[EMAIL PROTECTED]> The journal checksum feature adds two new flags i.e JBD2_FEATURE_INCOMPAT_ASYNC_COMMIT and JBD2_FEATURE_COMPAT_CHECKSUM. JBD2_FEATURE_CHECKSUM flag indicates that the commit block contains the checksum for the blocks described by the descriptor blocks.

[PATCH 33/49] ext4: Add the journal checksum feature

2008-01-21 Thread Theodore Ts'o
From: Girish Shilamkar [EMAIL PROTECTED] The journal checksum feature adds two new flags i.e JBD2_FEATURE_INCOMPAT_ASYNC_COMMIT and JBD2_FEATURE_COMPAT_CHECKSUM. JBD2_FEATURE_CHECKSUM flag indicates that the commit block contains the checksum for the blocks described by the descriptor blocks.