Re: [PATCH 34/33] netfs: Use in_interrupt() not in_softirq()

2021-02-16 Thread Christoph Hellwig
On Tue, Feb 16, 2021 at 09:29:31AM +, David Howells wrote: > Is there a better way to do it? The intent is to process the assessment phase > in the calling thread's context if possible rather than bumping over to a > worker thread. For synchronous I/O, for example, that's done in the

Re: [PATCH 34/33] netfs: Use in_interrupt() not in_softirq()

2021-02-16 Thread David Howells
Christoph Hellwig wrote: > On Mon, Feb 15, 2021 at 10:46:23PM +, David Howells wrote: > > The in_softirq() in netfs_rreq_terminated() works fine for the cache being > > on a normal disk, as the completion handlers may get called in softirq > > context, but for an NVMe drive, the completion

Re: [PATCH 34/33] netfs: Use in_interrupt() not in_softirq()

2021-02-16 Thread Sebastian Andrzej Siewior
On 2021-02-16 09:42:30 [+0100], Christoph Hellwig wrote: > On Mon, Feb 15, 2021 at 10:46:23PM +, David Howells wrote: > > The in_softirq() in netfs_rreq_terminated() works fine for the cache being > > on a normal disk, as the completion handlers may get called in softirq > > context, but for

Re: [PATCH 34/33] netfs: Use in_interrupt() not in_softirq()

2021-02-16 Thread Christoph Hellwig
On Mon, Feb 15, 2021 at 10:46:23PM +, David Howells wrote: > The in_softirq() in netfs_rreq_terminated() works fine for the cache being > on a normal disk, as the completion handlers may get called in softirq > context, but for an NVMe drive, the completion handler may get called in > IRQ

[PATCH 34/33] netfs: Use in_interrupt() not in_softirq()

2021-02-15 Thread David Howells
The in_softirq() in netfs_rreq_terminated() works fine for the cache being on a normal disk, as the completion handlers may get called in softirq context, but for an NVMe drive, the completion handler may get called in IRQ context. Fix to use in_interrupt() instead of in_softirq() throughout the