Re: [PATCH 34/38] arm: Implement thread_struct whitelist for hardened usercopy

2018-01-11 Thread Kees Cook
On Thu, Jan 11, 2018 at 2:24 AM, Russell King - ARM Linux wrote: > On Wed, Jan 10, 2018 at 06:03:06PM -0800, Kees Cook wrote: >> ARM does not carry FPU state in the thread structure, so it can declare >> no usercopy whitelist at all. > > This comment seems to be misleading. We have stored FP stat

Re: [PATCH 34/38] arm: Implement thread_struct whitelist for hardened usercopy

2018-01-11 Thread Russell King - ARM Linux
On Wed, Jan 10, 2018 at 06:03:06PM -0800, Kees Cook wrote: > ARM does not carry FPU state in the thread structure, so it can declare > no usercopy whitelist at all. This comment seems to be misleading. We have stored FP state in the thread structure for a long time - for example, VFP state is sto

[PATCH 34/38] arm: Implement thread_struct whitelist for hardened usercopy

2018-01-10 Thread Kees Cook
ARM does not carry FPU state in the thread structure, so it can declare no usercopy whitelist at all. Cc: Russell King Cc: Ingo Molnar Cc: Christian Borntraeger Cc: "Peter Zijlstra (Intel)" Cc: linux-arm-ker...@lists.infradead.org Signed-off-by: Kees Cook --- arch/arm/Kconfig