Re: [PATCH 35/35] cpufreq: tegra: use cpufreq_table_validate_and_show()

2013-08-12 Thread Viresh Kumar
On 12 August 2013 22:03, Stephen Warren wrote: > It's in defconfig OK; I think the driver simply isn't initializing since > some of the clocks it requests don't exist. I'll have our clock driver > author look into it. In the meantime, I assume that your change is > likely fine. I wasn't' talking

Re: [PATCH 35/35] cpufreq: tegra: use cpufreq_table_validate_and_show()

2013-08-12 Thread Stephen Warren
On 08/09/2013 08:53 PM, Viresh Kumar wrote: > On 10 August 2013 03:38, Stephen Warren wrote: >> Well, I don't see any issues running this, although the cpufreq sysfs >> files seem to have disappeared on Tegra, even without your changes, so >> I'm not sure how to really verify cpufreq. >> >> Did th

Re: [PATCH 35/35] cpufreq: tegra: use cpufreq_table_validate_and_show()

2013-08-09 Thread Viresh Kumar
On 10 August 2013 03:38, Stephen Warren wrote: > Well, I don't see any issues running this, although the cpufreq sysfs > files seem to have disappeared on Tegra, even without your changes, so > I'm not sure how to really verify cpufreq. > > Did the sysfs files go away, or do I need to investigate

Re: [PATCH 35/35] cpufreq: tegra: use cpufreq_table_validate_and_show()

2013-08-09 Thread Stephen Warren
On 08/09/2013 11:09 AM, Viresh Kumar wrote: > On 9 August 2013 21:49, Stephen Warren wrote: >> On 08/08/2013 10:04 PM, Viresh Kumar wrote: >>> On 8 August 2013 21:37, Viresh Kumar wrote: Its useless and the correct routine isn't called at all :) .. I will add that additional patch

Re: [PATCH 35/35] cpufreq: tegra: use cpufreq_table_validate_and_show()

2013-08-09 Thread Viresh Kumar
On 9 August 2013 21:49, Stephen Warren wrote: > On 08/08/2013 10:04 PM, Viresh Kumar wrote: >> On 8 August 2013 21:37, Viresh Kumar wrote: >>> Its useless and the correct routine isn't called at all :) .. I will add >>> that >>> additional patch and send it to you and will get this change out of

Re: [PATCH 35/35] cpufreq: tegra: use cpufreq_table_validate_and_show()

2013-08-09 Thread Stephen Warren
On 08/08/2013 10:04 PM, Viresh Kumar wrote: > On 8 August 2013 21:37, Viresh Kumar wrote: >> Its useless and the correct routine isn't called at all :) .. I will add that >> additional patch and send it to you and will get this change out of this >> commit. > > The two commits look like this now

Re: [PATCH 35/35] cpufreq: tegra: use cpufreq_table_validate_and_show()

2013-08-08 Thread Viresh Kumar
On 8 August 2013 21:37, Viresh Kumar wrote: > Its useless and the correct routine isn't called at all :) .. I will add that > additional patch and send it to you and will get this change out of this > commit. The two commits look like this now attached too in case you want to test: commit 9abdc9

Re: [PATCH 35/35] cpufreq: tegra: use cpufreq_table_validate_and_show()

2013-08-08 Thread Viresh Kumar
On 8 August 2013 21:14, Stephen Warren wrote: > On 08/08/2013 07:48 AM, Viresh Kumar wrote: >> Lets use cpufreq_table_validate_and_show() instead of calling >> cpufreq_frequency_table_cpuinfo() and cpufreq_frequency_table_get_attr(). > > Assuming the new function simply does what the two removed l

Re: [PATCH 35/35] cpufreq: tegra: use cpufreq_table_validate_and_show()

2013-08-08 Thread Stephen Warren
On 08/08/2013 07:48 AM, Viresh Kumar wrote: > Lets use cpufreq_table_validate_and_show() instead of calling > cpufreq_frequency_table_cpuinfo() and cpufreq_frequency_table_get_attr(). Assuming the new function simply does what the two removed lines do, this looks fine to me. > static int tegra_c

[PATCH 35/35] cpufreq: tegra: use cpufreq_table_validate_and_show()

2013-08-08 Thread Viresh Kumar
Lets use cpufreq_table_validate_and_show() instead of calling cpufreq_frequency_table_cpuinfo() and cpufreq_frequency_table_get_attr(). Cc: Stephen Warren Signed-off-by: Viresh Kumar --- drivers/cpufreq/tegra-cpufreq.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drive