Re: Re: [PATCH 35/36] hid: roccat: convert class code to use bin_attrs in groups

2013-08-20 Thread Greg KH
On Tue, Aug 20, 2013 at 07:28:46AM +0200, screamingf...@arcor.de wrote: > - Original Nachricht > Von: Greg Kroah-Hartman > An: Stefan Achatz > Datum: 15.08.2013 18:40 > Betreff: Re: [PATCH 35/36] hid: roccat: convert class code to use bin_attrs > in groups

Aw: Re: [PATCH 35/36] hid: roccat: convert class code to use bin_attrs in groups

2013-08-19 Thread screamingfist
- Original Nachricht Von: Greg Kroah-Hartman An: Stefan Achatz Datum: 15.08.2013 18:40 Betreff: Re: [PATCH 35/36] hid: roccat: convert class code to use bin_attrs in groups > On Thu, Aug 15, 2013 at 06:03:46PM +0200, Stefan Achatz wrote: > > Hello Greg, > >

Re: [PATCH 35/36] hid: roccat: convert class code to use bin_attrs in groups

2013-08-15 Thread Greg Kroah-Hartman
On Thu, Aug 15, 2013 at 06:03:46PM +0200, Stefan Achatz wrote: > Hello Greg, > looking through the patch I found the following: > > > > In hid-roccat-kone.c, PROFILE_ATTR macro: > The line > .private = &profile_numbers[number], > should read > .private = &profile_numbers[number-1], Ah, ok, th

Re: [PATCH 35/36] hid: roccat: convert class code to use bin_attrs in groups

2013-08-15 Thread Stefan Achatz
Hello Greg, looking through the patch I found the following: In hid-roccat-kone.c, PROFILE_ATTR macro: The line .private = &profile_numbers[number], should read .private = &profile_numbers[number-1], Regarding the compiler warning about unused pyra_sysfs_write_settings: The attribute is ind

[PATCH 35/36] hid: roccat: convert class code to use bin_attrs in groups

2013-07-24 Thread Greg Kroah-Hartman
Now that attribute groups support binary attributes, use them instead of the dev_bin_attrs field in struct class, as that is going away soon. Note, there is now a compiler warning about an unused function in the hid-roccat-pyra.c file with this patch: drivers/hid/hid-roccat-pyra.c:246:16: warning: