Re: [PATCH 36/51] writeback: implement bdi_for_each_wb()

2015-07-03 Thread Tejun Heo
On Fri, Jul 03, 2015 at 02:26:27PM +0200, Jan Kara wrote: > That's a good point. Thanks for explanation. Maybe add a comment like: > /* > * We use use this seemingly complicated 'for' loop so that 'break' and > * 'continue' continue to work as expected. > */ This kinda feel superflous for me.

Re: [PATCH 36/51] writeback: implement bdi_for_each_wb()

2015-07-03 Thread Jan Kara
On Wed 01-07-15 22:22:26, Tejun Heo wrote: > On Wed, Jul 01, 2015 at 09:27:57AM +0200, Jan Kara wrote: > > > +#define bdi_for_each_wb(wb_cur, bdi, iter, start_blkcg_id) > > > \ > > > + for ((iter)->next_id = (start_blkcg_id);\ > > > + ({ (wb_cur) = !(iter

Re: [PATCH 36/51] writeback: implement bdi_for_each_wb()

2015-07-01 Thread Tejun Heo
On Wed, Jul 01, 2015 at 09:27:57AM +0200, Jan Kara wrote: > > +#define bdi_for_each_wb(wb_cur, bdi, iter, start_blkcg_id) \ > > + for ((iter)->next_id = (start_blkcg_id);\ > > +({ (wb_cur) = !(iter)->next_id++ ? &(bdi)->wb : NULL; }); ) > > + > > This look

Re: [PATCH 36/51] writeback: implement bdi_for_each_wb()

2015-07-01 Thread Jan Kara
On Fri 22-05-15 17:13:50, Tejun Heo wrote: > This will be used to implement bdi-wide operations which should be > distributed across all its cgroup bdi_writebacks. > > Signed-off-by: Tejun Heo > Cc: Jens Axboe > Cc: Jan Kara One comment below. > @@ -445,6 +500,14 @@ static inline void wb_blkc

[PATCH 36/51] writeback: implement bdi_for_each_wb()

2015-05-22 Thread Tejun Heo
This will be used to implement bdi-wide operations which should be distributed across all its cgroup bdi_writebacks. Signed-off-by: Tejun Heo Cc: Jens Axboe Cc: Jan Kara --- include/linux/backing-dev.h | 63 + 1 file changed, 63 insertions(+) diff -