Re: [PATCH 37/74] lto, KVM: Don't assume asm statements end up in the same assembler file

2012-08-19 Thread Andi Kleen
On Sun, Aug 19, 2012 at 06:12:57PM +0300, Avi Kivity wrote: > On 08/19/2012 06:09 PM, Andi Kleen wrote: > >> The reason we use a local label is so that we the function isn't split > >> into two from the profiler's point of view. See cd2276a795b013d1. > > > > Hmm that commit message is not very en

Re: [PATCH 37/74] lto, KVM: Don't assume asm statements end up in the same assembler file

2012-08-19 Thread Avi Kivity
On 08/19/2012 06:09 PM, Andi Kleen wrote: >> The reason we use a local label is so that we the function isn't split >> into two from the profiler's point of view. See cd2276a795b013d1. > > Hmm that commit message is not very enlightening. > > The goal was to force a compiler error? No, the goal

Re: [PATCH 37/74] lto, KVM: Don't assume asm statements end up in the same assembler file

2012-08-19 Thread Andi Kleen
> The reason we use a local label is so that we the function isn't split > into two from the profiler's point of view. See cd2276a795b013d1. Hmm that commit message is not very enlightening. The goal was to force a compiler error? With LTO there is no way to force two functions be in the same a

Re: [PATCH 37/74] lto, KVM: Don't assume asm statements end up in the same assembler file

2012-08-19 Thread Avi Kivity
On 08/19/2012 05:56 AM, Andi Kleen wrote: > From: Andi Kleen > > The VMX code references a local assembler label between two inline > assembler statements. This assumes they both end up in the same > assembler files. In some experimental builds of gcc this is not > necessarily true, causing linke

[PATCH 37/74] lto, KVM: Don't assume asm statements end up in the same assembler file

2012-08-18 Thread Andi Kleen
From: Andi Kleen The VMX code references a local assembler label between two inline assembler statements. This assumes they both end up in the same assembler files. In some experimental builds of gcc this is not necessarily true, causing linker failures. Replace the local label reference with a