Re: [PATCH 38/42] drivers: gpio: vr41xx: use devm_platform_ioremap_resource()

2019-04-02 Thread Linus Walleij
On Tue, Mar 12, 2019 at 1:56 AM Enrico Weigelt, metux IT consult wrote: > Use the new helper that wraps the calls to platform_get_resource() > and devm_ioremap_resource() together. > > this driver deserves a bit more cleanup, to get rid of the global > variable giu_base, which makes it

Re: [PATCH 38/42] drivers: gpio: vr41xx: use devm_platform_ioremap_resource()

2019-03-12 Thread Florian Fainelli
On 3/12/2019 8:42 AM, Enrico Weigelt, metux IT consult wrote: > On 12.03.19 12:37, Thierry Reding wrote: > >> The driver currently doesn't request the memory described in the >> resource, so technically you're changing behaviour here and with your >> change the driver could now fail if

Re: [PATCH 38/42] drivers: gpio: vr41xx: use devm_platform_ioremap_resource()

2019-03-12 Thread Enrico Weigelt, metux IT consult
On 12.03.19 12:37, Thierry Reding wrote: > The driver currently doesn't request the memory described in the > resource, so technically you're changing behaviour here and with your > change the driver could now fail if somebody else has already claimed > the memory. hmm, using w/o

Re: [PATCH 38/42] drivers: gpio: vr41xx: use devm_platform_ioremap_resource()

2019-03-12 Thread Thierry Reding
On Mon, Mar 11, 2019 at 07:55:17PM +0100, Enrico Weigelt, metux IT consult wrote: > Use the new helper that wraps the calls to platform_get_resource() > and devm_ioremap_resource() together. > > this driver deserves a bit more cleanup, to get rid of the global > variable giu_base, which makes it

[PATCH 38/42] drivers: gpio: vr41xx: use devm_platform_ioremap_resource()

2019-03-11 Thread Enrico Weigelt, metux IT consult
Use the new helper that wraps the calls to platform_get_resource() and devm_ioremap_resource() together. this driver deserves a bit more cleanup, to get rid of the global variable giu_base, which makes it single-instance-only. Signed-off-by: Enrico Weigelt, metux IT consult ---