Re: [PATCH 4/11] i386 vDSO: use VM_ALWAYSDUMP

2007-01-23 Thread Roland McGrath
> Not that the old code did either, so it's not like it's a new bug, but I > thought I'd point it out anyway. As if we care (but you can probably > trigger this by having an app that does > > munmap(NULL, TASK_SIZE); > > which will cause a SIGSEGV on return (because the stack doesn't exist

Re: [PATCH 4/11] i386 vDSO: use VM_ALWAYSDUMP

2007-01-23 Thread Roland McGrath
> On Sat, 13 Jan 2007 21:34:28 -0800 (PST) > Roland McGrath <[EMAIL PROTECTED]> wrote: > > > +vma = vma->vm_next ?: vma == gate_vma ? NULL : gate_vma) { > > Painful. Can we do this? Can't stand concise, eh? ;-) Your version is fine with me. Thanks, Roland - To unsubscribe from this

Re: [PATCH 4/11] i386 vDSO: use VM_ALWAYSDUMP

2007-01-23 Thread Linus Torvalds
On Tue, 23 Jan 2007, Andrew Morton wrote: > > /* > + * Helper function for iterating across a vma list. It ensures that the > caller > + * will visit `gate_vma' prior to terminating the search. Well, the comment is wrong. The code doesn't actually visit 'gate_vma' if the list of VMA's is e

Re: [PATCH 4/11] i386 vDSO: use VM_ALWAYSDUMP

2007-01-23 Thread Andrew Morton
On Sat, 13 Jan 2007 21:34:28 -0800 (PST) Roland McGrath <[EMAIL PROTECTED]> wrote: > + vma = vma->vm_next ?: vma == gate_vma ? NULL : gate_vma) { Painful. Can we do this? diff -puN fs/binfmt_elf.c~i386-vdso-use-vm_alwaysdump-tidy fs/binfmt_elf.c --- a/fs/binfmt_elf.c~i386-vdso-use-vm

[PATCH 4/11] i386 vDSO: use VM_ALWAYSDUMP

2007-01-13 Thread Roland McGrath
This patch fixes core dumps to include the vDSO vma, which is left out now. It removes the special-case core writing macros, which were not doing the right thing for the vDSO vma anyway. Instead, it uses VM_ALWAYSDUMP in the vma; there is no need for the fixmap page to be installed. It handles t