Re: [PATCH 4/4][RFC v2] x86/apic: Spread the vectors by choosing the idlest CPU

2017-09-07 Thread Thomas Gleixner
On Thu, 7 Sep 2017, Yu Chen wrote: > On Thu, Sep 07, 2017 at 07:54:09AM +0200, Thomas Gleixner wrote: > > Please switch it over to managed interrupts so the affinity spreading > > happens in a sane way and the interrupts are properly managed on CPU > > hotplug. > Ok, I think currently in i40e drive

Re: [PATCH 4/4][RFC v2] x86/apic: Spread the vectors by choosing the idlest CPU

2017-09-07 Thread Yu Chen
On Thu, Sep 07, 2017 at 07:54:09AM +0200, Thomas Gleixner wrote: > On Thu, 7 Sep 2017, Yu Chen wrote: > > On Wed, Sep 06, 2017 at 10:03:58AM +0200, Thomas Gleixner wrote: > > > Can you please apply the debug patch below, boot the machine and right > > > after login provide the output of > > > > >

Re: [PATCH 4/4][RFC v2] x86/apic: Spread the vectors by choosing the idlest CPU

2017-09-07 Thread Thomas Gleixner
On Wed, 6 Sep 2017, Dan Williams wrote: > On Wed, Sep 6, 2017 at 10:59 PM, Thomas Gleixner wrote: > >> commit 7c9ae7f053e9e896c24fd23595ba369a5fe322e1 > > > > -ENOSUCHCOMMIT > > Sorry, that's still pending in -next. Ok. > >> Author: Carolyn Wyborny > >> Date: Tue Jun 20 15:16:53 2017 -0700 >

Re: [PATCH 4/4][RFC v2] x86/apic: Spread the vectors by choosing the idlest CPU

2017-09-06 Thread Dan Williams
On Wed, Sep 6, 2017 at 10:59 PM, Thomas Gleixner wrote: > On Wed, 6 Sep 2017, Dan Williams wrote: > >> On Tue, Sep 5, 2017 at 11:15 PM, Christoph Hellwig wrote: >> > On Wed, Sep 06, 2017 at 12:13:38PM +0800, Yu Chen wrote: >> >> I agree, the driver could be rewritten, but it might take some time,

Re: [PATCH 4/4][RFC v2] x86/apic: Spread the vectors by choosing the idlest CPU

2017-09-06 Thread Thomas Gleixner
On Wed, 6 Sep 2017, Dan Williams wrote: > On Tue, Sep 5, 2017 at 11:15 PM, Christoph Hellwig wrote: > > On Wed, Sep 06, 2017 at 12:13:38PM +0800, Yu Chen wrote: > >> I agree, the driver could be rewritten, but it might take some time, so > >> meanwhile I'm looking at also other possible optimizat

Re: [PATCH 4/4][RFC v2] x86/apic: Spread the vectors by choosing the idlest CPU

2017-09-06 Thread Thomas Gleixner
On Thu, 7 Sep 2017, Yu Chen wrote: > On Wed, Sep 06, 2017 at 10:03:58AM +0200, Thomas Gleixner wrote: > > Can you please apply the debug patch below, boot the machine and right > > after login provide the output of > > > > # cat /sys/kernel/debug/tracing/trace > > > kworker/0:2-303 [000] ..

Re: [PATCH 4/4][RFC v2] x86/apic: Spread the vectors by choosing the idlest CPU

2017-09-06 Thread Yu Chen
On Wed, Sep 06, 2017 at 10:46:17AM -0700, Dan Williams wrote: > On Tue, Sep 5, 2017 at 11:15 PM, Christoph Hellwig wrote: > > On Wed, Sep 06, 2017 at 12:13:38PM +0800, Yu Chen wrote: > >> I agree, the driver could be rewritten, but it might take some time, so > >> meanwhile I'm looking at also oth

Re: [PATCH 4/4][RFC v2] x86/apic: Spread the vectors by choosing the idlest CPU

2017-09-06 Thread Yu Chen
On Wed, Sep 06, 2017 at 10:03:58AM +0200, Thomas Gleixner wrote: > On Wed, 6 Sep 2017, Yu Chen wrote: > > On Wed, Sep 06, 2017 at 12:57:41AM +0200, Thomas Gleixner wrote: > > > I have a hard time to figure out how the 133 vectors on CPU31 are now > > > magically fitting in the empty space on CPU0,

Re: [PATCH 4/4][RFC v2] x86/apic: Spread the vectors by choosing the idlest CPU

2017-09-06 Thread Dan Williams
On Tue, Sep 5, 2017 at 11:15 PM, Christoph Hellwig wrote: > On Wed, Sep 06, 2017 at 12:13:38PM +0800, Yu Chen wrote: >> I agree, the driver could be rewritten, but it might take some time, so >> meanwhile I'm looking at also other possible optimization. > > Which driver are we talking about anyway

Re: [PATCH 4/4][RFC v2] x86/apic: Spread the vectors by choosing the idlest CPU

2017-09-06 Thread Thomas Gleixner
On Wed, 6 Sep 2017, Yu Chen wrote: > On Wed, Sep 06, 2017 at 12:57:41AM +0200, Thomas Gleixner wrote: > > I have a hard time to figure out how the 133 vectors on CPU31 are now > > magically fitting in the empty space on CPU0, which is 204 - 133 = 71. In > > my limited understanding of math 133 is g

Re: [PATCH 4/4][RFC v2] x86/apic: Spread the vectors by choosing the idlest CPU

2017-09-05 Thread Christoph Hellwig
On Wed, Sep 06, 2017 at 12:13:38PM +0800, Yu Chen wrote: > I agree, the driver could be rewritten, but it might take some time, so > meanwhile I'm looking at also other possible optimization. Which driver are we talking about anyway? Let's start looking at it and fix the issue there.

Re: [PATCH 4/4][RFC v2] x86/apic: Spread the vectors by choosing the idlest CPU

2017-09-05 Thread Yu Chen
On Wed, Sep 06, 2017 at 12:57:41AM +0200, Thomas Gleixner wrote: > On Sun, 3 Sep 2017, Thomas Gleixner wrote: > > > On Fri, 1 Sep 2017, Chen Yu wrote: > > > > > This is the major logic to spread the vectors on different CPUs. > > > The main idea is to choose the 'idlest' CPU which has assigned >

Re: [PATCH 4/4][RFC v2] x86/apic: Spread the vectors by choosing the idlest CPU

2017-09-05 Thread Yu Chen
Thanks for looking at this, (please bear my slow response as I need to check related code before replying.) On Sun, Sep 03, 2017 at 08:17:04PM +0200, Thomas Gleixner wrote: > On Fri, 1 Sep 2017, Chen Yu wrote: > > > This is the major logic to spread the vectors on different CPUs. > > The main idea

Re: [PATCH 4/4][RFC v2] x86/apic: Spread the vectors by choosing the idlest CPU

2017-09-05 Thread Thomas Gleixner
On Sun, 3 Sep 2017, Thomas Gleixner wrote: > On Fri, 1 Sep 2017, Chen Yu wrote: > > > This is the major logic to spread the vectors on different CPUs. > > The main idea is to choose the 'idlest' CPU which has assigned > > the least number of vectors as the candidate/hint for the vector > > alloca

Re: [PATCH 4/4][RFC v2] x86/apic: Spread the vectors by choosing the idlest CPU

2017-09-03 Thread Thomas Gleixner
On Fri, 1 Sep 2017, Chen Yu wrote: > This is the major logic to spread the vectors on different CPUs. > The main idea is to choose the 'idlest' CPU which has assigned > the least number of vectors as the candidate/hint for the vector > allocation domain, in the hope that the vector allocation doma

[PATCH 4/4][RFC v2] x86/apic: Spread the vectors by choosing the idlest CPU

2017-08-31 Thread Chen Yu
This is the major logic to spread the vectors on different CPUs. The main idea is to choose the 'idlest' CPU which has assigned the least number of vectors as the candidate/hint for the vector allocation domain, in the hope that the vector allocation domain could leverage this hint to generate corr