Re: [alsa-devel] [PATCH 4/4] ALSA: usb: add UAC3 BADD profiles support

2018-04-24 Thread Ruslan Bilovol
On Thu, Apr 19, 2018 at 1:19 PM, Takashi Iwai wrote: > On Sat, 14 Apr 2018 00:24:26 +0200, > Ruslan Bilovol wrote: >> >> +static void build_feature_ctl_badd(struct usb_mixer_interface *mixer, >> + unsigned int ctl_mask, int control, int unitid, >> +

Re: [alsa-devel] [PATCH 4/4] ALSA: usb: add UAC3 BADD profiles support

2018-04-23 Thread Ruslan Bilovol
On Thu, Apr 19, 2018 at 12:42 PM, Andrew Chant wrote: > On Sat, Apr 14, 2018 at 6:24 AM, Ruslan Bilovol > wrote: >> Recently released USB Audio Class 3.0 specification >> contains BADD (Basic Audio Device Definition) document >> which describes pre-defined UAC3 configurations. >> >> BADD support

Re: [alsa-devel] [PATCH 4/4] ALSA: usb: add UAC3 BADD profiles support

2018-04-19 Thread Takashi Iwai
On Sat, 14 Apr 2018 00:24:26 +0200, Ruslan Bilovol wrote: > > +static void build_feature_ctl_badd(struct usb_mixer_interface *mixer, > + unsigned int ctl_mask, int control, int unitid, > + const struct usbmix_name_map *badd_map) > +{ > +

Re: [alsa-devel] [PATCH 4/4] ALSA: usb: add UAC3 BADD profiles support

2018-04-19 Thread Andrew Chant
On Sat, Apr 14, 2018 at 6:24 AM, Ruslan Bilovol wrote: > Recently released USB Audio Class 3.0 specification > contains BADD (Basic Audio Device Definition) document > which describes pre-defined UAC3 configurations. > > BADD support is mandatory for UAC3 devices, it should be > implemented as a s

Re: [PATCH 4/4] ALSA: usb: add UAC3 BADD profiles support

2018-04-17 Thread Ruslan Bilovol
On Sat, Apr 14, 2018 at 8:55 PM, Jorge Sanjuan wrote: > > > On 2018-04-13 23:24, Ruslan Bilovol wrote: >> >> Recently released USB Audio Class 3.0 specification >> contains BADD (Basic Audio Device Definition) document >> which describes pre-defined UAC3 configurations. >> >> BADD support is manda

Re: [PATCH 4/4] ALSA: usb: add UAC3 BADD profiles support

2018-04-16 Thread kbuild test robot
Hi Ruslan, Thank you for the patch! Perhaps something to improve: url: https://github.com/0day-ci/linux/commits/Ruslan-Bilovol/USB-Audio-Device-Class-3-0-BADD-profiles-support/20180414-182703 base: https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git for-next smatch warnings: so

Re: [PATCH 4/4] ALSA: usb: add UAC3 BADD profiles support

2018-04-14 Thread Jorge Sanjuan
On 2018-04-13 23:24, Ruslan Bilovol wrote: Recently released USB Audio Class 3.0 specification contains BADD (Basic Audio Device Definition) document which describes pre-defined UAC3 configurations. BADD support is mandatory for UAC3 devices, it should be implemented as a separate USB device c

[PATCH 4/4] ALSA: usb: add UAC3 BADD profiles support

2018-04-13 Thread Ruslan Bilovol
Recently released USB Audio Class 3.0 specification contains BADD (Basic Audio Device Definition) document which describes pre-defined UAC3 configurations. BADD support is mandatory for UAC3 devices, it should be implemented as a separate USB device configuration. As per BADD document, class-speci