Re: [PATCH 4/4] HID: input: map battery capacity (00850065)

2021-03-27 Thread kernel test robot
Hi John, Thank you for the patch! Yet something to improve: [auto build test ERROR on hid/for-next] [also build test ERROR on linux/master linus/master jikos-hid/for-next jikos-trivial/for-next v5.12-rc4 next-20210326] [If your patch is applied to the wrong git tree, kindly drop us a note. And w

Re: [PATCH 4/4] HID: input: map battery capacity (00850065)

2021-03-27 Thread kernel test robot
Hi John, Thank you for the patch! Yet something to improve: [auto build test ERROR on hid/for-next] [also build test ERROR on linux/master linus/master v5.12-rc4 next-20210326] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--

Re: [PATCH 4/4] HID: input: map battery capacity (00850065)

2021-03-27 Thread Pochang Chen
On Sat, Mar 27, 2021 at 9:06 PM John Chen wrote: > + hidinput_setup_battery(device, HID_INPUT_REPORT, > field); > + usage->type = EV_PWR; > + device->battery_min = 0; > + device->battery_max = 100; I just rea

[PATCH 4/4] HID: input: map battery capacity (00850065)

2021-03-27 Thread John Chen
This is the capacity in percentage, relative to design capacity. Specifically, it is present in Apple Magic Mouse 2. In contrast, usage 00850064 is also the capacity in percentage, but is relative to full capacity. It is not mapped here because I don't have such device. Signed-off-by: John Chen