Re: [PATCH 4/4] PM / Domains: Propagate performance state updates

2018-11-20 Thread Rajendra Nayak
On 11/21/2018 12:06 PM, Viresh Kumar wrote: On 21-11-18, 11:12, Rajendra Nayak wrote: And the reason for that seems to be that we update the genpd status to GPD_STATE_ACTIVE *after* we try to set the performance state, so we always hit this check which bails out thinking the genpd is not ON

Re: [PATCH 4/4] PM / Domains: Propagate performance state updates

2018-11-20 Thread Viresh Kumar
On 21-11-18, 11:12, Rajendra Nayak wrote: > And the reason for that seems to be that we update the genpd status to > GPD_STATE_ACTIVE > *after* we try to set the performance state, so we always hit this check > which bails out > thinking the genpd is not ON. Thanks for looking at it. Here is the

Re: [PATCH 4/4] PM / Domains: Propagate performance state updates

2018-11-20 Thread Rajendra Nayak
On 11/21/2018 11:01 AM, Rajendra Nayak wrote: On 11/21/2018 10:46 AM, Viresh Kumar wrote: On 21-11-18, 10:33, Rajendra Nayak wrote: Hi Viresh, On 11/5/2018 12:06 PM, Viresh Kumar wrote: This commit updates genpd core to start propagating performance state updates to master domains that ha

Re: [PATCH 4/4] PM / Domains: Propagate performance state updates

2018-11-20 Thread Viresh Kumar
On 21-11-18, 11:01, Rajendra Nayak wrote: > I would think this is analogous to a driver calling clk_set_rate() first and > then a clk_enable(), which is certainly valid. > So my question is, if calling a dev_pm_genpd_set_performance_state() > and then runtime enabling the device would work (and tak

Re: [PATCH 4/4] PM / Domains: Propagate performance state updates

2018-11-20 Thread Rajendra Nayak
On 11/21/2018 10:46 AM, Viresh Kumar wrote: On 21-11-18, 10:33, Rajendra Nayak wrote: Hi Viresh, On 11/5/2018 12:06 PM, Viresh Kumar wrote: This commit updates genpd core to start propagating performance state updates to master domains that have their set_performance_state() callback set.

Re: [PATCH 4/4] PM / Domains: Propagate performance state updates

2018-11-20 Thread Viresh Kumar
On 21-11-18, 10:33, Rajendra Nayak wrote: > Hi Viresh, > > On 11/5/2018 12:06 PM, Viresh Kumar wrote: > > This commit updates genpd core to start propagating performance state > > updates to master domains that have their set_performance_state() > > callback set. > > > > A genpd handles two type

Re: [PATCH 4/4] PM / Domains: Propagate performance state updates

2018-11-20 Thread Rajendra Nayak
Hi Viresh, On 11/5/2018 12:06 PM, Viresh Kumar wrote: This commit updates genpd core to start propagating performance state updates to master domains that have their set_performance_state() callback set. A genpd handles two type of performance states now. The first one is the performance state

[PATCH 4/4] PM / Domains: Propagate performance state updates

2018-11-04 Thread Viresh Kumar
This commit updates genpd core to start propagating performance state updates to master domains that have their set_performance_state() callback set. A genpd handles two type of performance states now. The first one is the performance state requirement put on the genpd by the devices and sub-domai