Re: [PATCH 4/4] PM / devfreq: Handle monitor start/stop in the devfreq core

Hi Matthias, On 19. 2. 16. 오전 7:56, Matthias Kaehlcke wrote: > Hi Chanwoo, > > On Fri, Feb 15, 2019 at 09:33:05AM +0900, Chanwoo Choi wrote: >> Hi Matthias, >> >> On 19. 2. 15. 오전 9:19, Matthias Kaehlcke wrote: >>> Hi Chanwoo, >>> >>> On Fri, Feb 15, 2019 at 08:42:30AM +0900, Chanwoo Choi wrote:

Re: [PATCH 4/4] PM / devfreq: Handle monitor start/stop in the devfreq core

Hi Chanwoo, On Fri, Feb 15, 2019 at 09:33:05AM +0900, Chanwoo Choi wrote: > Hi Matthias, > > On 19. 2. 15. 오전 9:19, Matthias Kaehlcke wrote: > > Hi Chanwoo, > > > > On Fri, Feb 15, 2019 at 08:42:30AM +0900, Chanwoo Choi wrote: > >> Hi Matthias, > >> > >> On 19. 2. 15. 오전 4:28, Matthias Kaehlcke

Re: [PATCH 4/4] PM / devfreq: Handle monitor start/stop in the devfreq core

Hi Matthias, On 2/14/19 8:07 PM, Matthias Kaehlcke wrote: > Hi Lukasz, > > On Thu, Feb 14, 2019 at 07:01:36PM +0100, Lukasz Luba wrote: >> Hi Matthias, >> >> I have compiled and run your changes on Odroid xu3 and v5.0-rc6. >> There are kernel warnings because of mutex not held in function >>

Re: [PATCH 4/4] PM / devfreq: Handle monitor start/stop in the devfreq core

Hi Matthias, On 19. 2. 15. 오전 9:19, Matthias Kaehlcke wrote: > Hi Chanwoo, > > On Fri, Feb 15, 2019 at 08:42:30AM +0900, Chanwoo Choi wrote: >> Hi Matthias, >> >> On 19. 2. 15. 오전 4:28, Matthias Kaehlcke wrote: >>> Hi Chanwoo, >>> >>> On Thu, Feb 14, 2019 at 11:17:36PM +0900, Chanwoo Choi wrote:

Re: [PATCH 4/4] PM / devfreq: Handle monitor start/stop in the devfreq core

Hi Chanwoo, On Fri, Feb 15, 2019 at 08:42:30AM +0900, Chanwoo Choi wrote: > Hi Matthias, > > On 19. 2. 15. 오전 4:28, Matthias Kaehlcke wrote: > > Hi Chanwoo, > > > > On Thu, Feb 14, 2019 at 11:17:36PM +0900, Chanwoo Choi wrote: > >> Hi Matthias, > >> > >> As I commented on the first patch, it is

Re: [PATCH 4/4] PM / devfreq: Handle monitor start/stop in the devfreq core

Hi Matthias, On 19. 2. 15. 오전 4:28, Matthias Kaehlcke wrote: > Hi Chanwoo, > > On Thu, Feb 14, 2019 at 11:17:36PM +0900, Chanwoo Choi wrote: >> Hi Matthias, >> >> As I commented on the first patch, it is not possible to call some codes >> according to the intention of each governor between

Re: [PATCH 4/4] PM / devfreq: Handle monitor start/stop in the devfreq core

Hi Chanwoo, On Thu, Feb 14, 2019 at 11:17:36PM +0900, Chanwoo Choi wrote: > Hi Matthias, > > As I commented on the first patch, it is not possible to call some codes > according to the intention of each governor between 'devfreq_moniotr_*()' > and some codes which are executed before or after

Re: [PATCH 4/4] PM / devfreq: Handle monitor start/stop in the devfreq core

Hi Lukasz, On Thu, Feb 14, 2019 at 07:01:36PM +0100, Lukasz Luba wrote: > Hi Matthias, > > I have compiled and run your changes on Odroid xu3 and v5.0-rc6. > There are kernel warnings because of mutex not held in function > devfreq_monitor_[start|stop]() in use cases: > 1) a few times during

Re: [PATCH 4/4] PM / devfreq: Handle monitor start/stop in the devfreq core

Hi Matthias, I have compiled and run your changes on Odroid xu3 and v5.0-rc6. There are kernel warnings because of mutex not held in function devfreq_monitor_[start|stop]() in use cases: 1) a few times during registration of new devices devfreq_add_device() 2) poking the device from sysfs ad

Re: [PATCH 4/4] PM / devfreq: Handle monitor start/stop in the devfreq core

Hi Matthias, As I commented on the first patch, it is not possible to call some codes according to the intention of each governor between 'devfreq_moniotr_*()' and some codes which are executed before or after 'devfreq_moniotr_*()' For example, if some governor requires the following sequence,

[PATCH 4/4] PM / devfreq: Handle monitor start/stop in the devfreq core

devfreq expects governors to call devfreq_monitor_start/stop() in response to DEVFREQ_GOV_START/STOP events. Since the devfreq core itself generates these events and invokes the governor's event handler the start/stop of the load monitor can be done in the common code. Call