In message <[EMAIL PROTECTED]>,"Rober
t P. J. Day" writes:
>> > in any event, i just thought i'd point it out. if you're absolutely
>> > sure there will never be another call to setup_dev() from somewhere
>> > else, then, yes, it's safe.
>>
>> I understood your opinions. and partially agree with
In message [EMAIL PROTECTED],Rober
t P. J. Day writes:
in any event, i just thought i'd point it out. if you're absolutely
sure there will never be another call to setup_dev() from somewhere
else, then, yes, it's safe.
I understood your opinions. and partially agree with you.
But isn't
On Mon, 26 Nov 2007, Joonwoo Park wrote:
> 2007/11/26, Robert P. J. Day <[EMAIL PROTECTED]>:
> > i realized that. but all you can say is that only amb_init() calls
> > setup_dev() *currently*. when you're not looking, someone else might
> > (for whatever reason) call setup_dev() from elsewhere,
2007/11/26, Robert P. J. Day <[EMAIL PROTECTED]>:
> i realized that. but all you can say is that only amb_init() calls
> setup_dev() *currently*. when you're not looking, someone else might
> (for whatever reason) call setup_dev() from elsewhere, and *that* call
> might not zero that memory
On Mon, 26 Nov 2007, Joonwoo Park wrote:
> 2007/11/26, Robert P. J. Day <[EMAIL PROTECTED]>:
> > i'm not sure the above is a safe thing to do, as you're zeroing that
> > area, then making a function call and assuming, upon entry to the
> > function call, that the caller has done the right thing.
2007/11/26, Robert P. J. Day <[EMAIL PROTECTED]>:
> i'm not sure the above is a safe thing to do, as you're zeroing that
> area, then making a function call and assuming, upon entry to the
> function call, that the caller has done the right thing. i don't see
> how you can count on that,
On Mon, 26 Nov 2007, Joonwoo Park wrote:
> atm/ambassador: kmalloc + memset conversion to kzalloc
>
> Signed-off-by: Joonwoo Park <[EMAIL PROTECTED]>
>
> Thanks.
> Joonwoo
>
> ---
> diff --git a/drivers/atm/ambassador.c b/drivers/atm/ambassador.c
> index b34b382..4f99ba3 100644
> ---
atm/ambassador: kmalloc + memset conversion to kzalloc
Signed-off-by: Joonwoo Park <[EMAIL PROTECTED]>
Thanks.
Joonwoo
---
diff --git a/drivers/atm/ambassador.c b/drivers/atm/ambassador.c
index b34b382..4f99ba3 100644
--- a/drivers/atm/ambassador.c
+++ b/drivers/atm/ambassador.c
@@ -2163,7
atm/ambassador: kmalloc + memset conversion to kzalloc
Signed-off-by: Joonwoo Park [EMAIL PROTECTED]
Thanks.
Joonwoo
---
diff --git a/drivers/atm/ambassador.c b/drivers/atm/ambassador.c
index b34b382..4f99ba3 100644
--- a/drivers/atm/ambassador.c
+++ b/drivers/atm/ambassador.c
@@ -2163,7
On Mon, 26 Nov 2007, Joonwoo Park wrote:
atm/ambassador: kmalloc + memset conversion to kzalloc
Signed-off-by: Joonwoo Park [EMAIL PROTECTED]
Thanks.
Joonwoo
---
diff --git a/drivers/atm/ambassador.c b/drivers/atm/ambassador.c
index b34b382..4f99ba3 100644
---
2007/11/26, Robert P. J. Day [EMAIL PROTECTED]:
i'm not sure the above is a safe thing to do, as you're zeroing that
area, then making a function call and assuming, upon entry to the
function call, that the caller has done the right thing. i don't see
how you can count on that, depending on
On Mon, 26 Nov 2007, Joonwoo Park wrote:
2007/11/26, Robert P. J. Day [EMAIL PROTECTED]:
i'm not sure the above is a safe thing to do, as you're zeroing that
area, then making a function call and assuming, upon entry to the
function call, that the caller has done the right thing. i don't
2007/11/26, Robert P. J. Day [EMAIL PROTECTED]:
i realized that. but all you can say is that only amb_init() calls
setup_dev() *currently*. when you're not looking, someone else might
(for whatever reason) call setup_dev() from elsewhere, and *that* call
might not zero that memory area.
On Mon, 26 Nov 2007, Joonwoo Park wrote:
2007/11/26, Robert P. J. Day [EMAIL PROTECTED]:
i realized that. but all you can say is that only amb_init() calls
setup_dev() *currently*. when you're not looking, someone else might
(for whatever reason) call setup_dev() from elsewhere, and
14 matches
Mail list logo
