Re: [PATCH 4/4] drivers/misc/sgi-gru: fix dereference of ERR_PTR

2015-09-02 Thread Dimitri Sivanich
On Wed, Sep 02, 2015 at 04:54:58PM +0530, Sudip Mukherjee wrote: > gru_alloc_gts() can fail and it can return ERR_PTR(errvalue). We should > not dereference it if it has returned error. And incase it has returned > error then just downgrade the write lock and exit. > Not sure about this, because

[PATCH 4/4] drivers/misc/sgi-gru: fix dereference of ERR_PTR

2015-09-02 Thread Sudip Mukherjee
gru_alloc_gts() can fail and it can return ERR_PTR(errvalue). We should not dereference it if it has returned error. And incase it has returned error then just downgrade the write lock and exit. Signed-off-by: Sudip Mukherjee --- drivers/misc/sgi-gru/grukservices.c | 3 +++ 1 file changed, 3

Re: [PATCH 4/4] drivers/misc/sgi-gru: fix dereference of ERR_PTR

2015-09-02 Thread Dimitri Sivanich
On Wed, Sep 02, 2015 at 04:54:58PM +0530, Sudip Mukherjee wrote: > gru_alloc_gts() can fail and it can return ERR_PTR(errvalue). We should > not dereference it if it has returned error. And incase it has returned > error then just downgrade the write lock and exit. > Not sure about this, because

[PATCH 4/4] drivers/misc/sgi-gru: fix dereference of ERR_PTR

2015-09-02 Thread Sudip Mukherjee
gru_alloc_gts() can fail and it can return ERR_PTR(errvalue). We should not dereference it if it has returned error. And incase it has returned error then just downgrade the write lock and exit. Signed-off-by: Sudip Mukherjee --- drivers/misc/sgi-gru/grukservices.c | 3