Re: [PATCH 4/4] drivers/mtd/nand/mpc5121_nfc.c: some devm_ cleanups

2012-09-04 Thread Artem Bityutskiy
On Tue, 2012-09-04 at 11:44 +0200, Julia Lawall wrote: > > I've been bitten by the same issue recently, also cause by one of these > > cocci devm patches. devm_clk_get is only available if the generic > > clk_get/clk_put implementation is used. Not all architectures do this and > > some implement t

Re: [PATCH 4/4] drivers/mtd/nand/mpc5121_nfc.c: some devm_ cleanups

2012-09-04 Thread Julia Lawall
On Tue, 4 Sep 2012, Lars-Peter Clausen wrote: > On 09/04/2012 10:42 AM, Artem Bityutskiy wrote: > > Aiaiai! :-) [1] [2] > > > > I've build-tested this using aiaiai and it reports that this change breaks > > the build: > > > > dedekind@blue:~/git/maintaining$ ./verify ../l2-mtd/ mpc5121_nfc < > >

Re: [PATCH 4/4] drivers/mtd/nand/mpc5121_nfc.c: some devm_ cleanups

2012-09-04 Thread Lars-Peter Clausen
On 09/04/2012 10:42 AM, Artem Bityutskiy wrote: > Aiaiai! :-) [1] [2] > > I've build-tested this using aiaiai and it reports that this change breaks > the build: > > dedekind@blue:~/git/maintaining$ ./verify ../l2-mtd/ mpc5121_nfc < > ~/tmp/julia2.mbox > Tested the patch(es) on top of the foll

Re: [PATCH 4/4] drivers/mtd/nand/mpc5121_nfc.c: some devm_ cleanups

2012-09-04 Thread Artem Bityutskiy
Aiaiai! :-) [1] [2] I've build-tested this using aiaiai and it reports that this change breaks the build: dedekind@blue:~/git/maintaining$ ./verify ../l2-mtd/ mpc5121_nfc < ~/tmp/julia2.mbox Tested the patch(es) on top of the following commits: ba64756 Quick fixes - applied by aiaiai 651c6fa J

[PATCH 4/4] drivers/mtd/nand/mpc5121_nfc.c: some devm_ cleanups

2012-09-01 Thread Julia Lawall
From: Julia Lawall devm free functions should not have to be explicitly used. The only thing left that is useful in the function mpc5121_nfc_free is the call to clk_disable, which is moved to the call sites. This function also incorrectly called iounmap on devm_ioremap allocated data. Use devm