Re: [PATCH 4/4] drm/gma500: avoid Woverride-init warning

2020-10-28 Thread Patrik Jakobsson
On Tue, Oct 27, 2020 at 5:50 PM Arnd Bergmann wrote: > > On Tue, Oct 27, 2020 at 10:54 AM Patrik Jakobsson > wrote: > > On Tue, Oct 27, 2020 at 10:33 AM Daniel Vetter wrote: > > > On Mon, Oct 26, 2020 at 08:41:04PM +0100, Arnd Bergmann wrote: > > > > From: Arnd Bergmann > > > > > > > > gcc -Wex

Re: [PATCH 4/4] drm/gma500: avoid Woverride-init warning

2020-10-27 Thread Arnd Bergmann
On Tue, Oct 27, 2020 at 10:54 AM Patrik Jakobsson wrote: > On Tue, Oct 27, 2020 at 10:33 AM Daniel Vetter wrote: > > On Mon, Oct 26, 2020 at 08:41:04PM +0100, Arnd Bergmann wrote: > > > From: Arnd Bergmann > > > > > > gcc -Wextra notices that one of the fields in psbfb_roll_ops has two > > > ini

Re: [PATCH 4/4] drm/gma500: avoid Woverride-init warning

2020-10-27 Thread Patrik Jakobsson
On Tue, Oct 27, 2020 at 10:33 AM Daniel Vetter wrote: > > On Mon, Oct 26, 2020 at 08:41:04PM +0100, Arnd Bergmann wrote: > > From: Arnd Bergmann > > > > gcc -Wextra notices that one of the fields in psbfb_roll_ops has two > > initializers: > > > > drivers/gpu/drm/gma500/framebuffer.c:185:20: warn

Re: [PATCH 4/4] drm/gma500: avoid Woverride-init warning

2020-10-27 Thread Daniel Vetter
On Mon, Oct 26, 2020 at 08:41:04PM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > > gcc -Wextra notices that one of the fields in psbfb_roll_ops has two > initializers: > > drivers/gpu/drm/gma500/framebuffer.c:185:20: warning: initialized field > overwritten [-Woverride-init] > > Open-cod

[PATCH 4/4] drm/gma500: avoid Woverride-init warning

2020-10-26 Thread Arnd Bergmann
From: Arnd Bergmann gcc -Wextra notices that one of the fields in psbfb_roll_ops has two initializers: drivers/gpu/drm/gma500/framebuffer.c:185:20: warning: initialized field overwritten [-Woverride-init] Open-code this instead, leaving out the extraneous initializers for .fb_pan_display. Fix