Hi Peter.
Always good to see that feedback input is used.
> OK.
>
> >> +
> >> + return 0;
> >> +}
> >> +
> >> +static void osd101t2587_panel_shutdown(struct mipi_dsi_device *dsi)
> >> +{
> >> + struct osd101t2587_panel *osd101t2587 = mipi_dsi_get_drvdata(dsi);
> >> +
> > Maybe call
Hi Sam,
On 20/02/2019 13.52, Sam Ravnborg wrote:
> Hi Peter.
>
> On Wed, Feb 20, 2019 at 12:39:11PM +0200, Peter Ujfalusi wrote:
>> Hi Sam,
>>
>> On 15/02/2019 20.07, Sam Ravnborg wrote:
+#include
+#include
+#include
+#include
+
+#include
>>> Please do not use
Hi Peter.
On Wed, Feb 20, 2019 at 12:39:11PM +0200, Peter Ujfalusi wrote:
> Hi Sam,
>
> On 15/02/2019 20.07, Sam Ravnborg wrote:
> >> +#include
> >> +#include
> >> +#include
> >> +#include
> >> +
> >> +#include
> > Please do not use drmP.h in new drivers - we try to get rid of this file.
>
Hi Sam,
On 15/02/2019 20.07, Sam Ravnborg wrote:
>> +#include
>> +#include
>> +#include
>> +#include
>> +
>> +#include
> Please do not use drmP.h in new drivers - we try to get rid of this file.
...
>> +static int osd101t2587_panel_get_modes(struct drm_panel *panel)
>> +{
>> +struct
Hi Sam,
On 15/02/2019 20.07, Sam Ravnborg wrote:
> Hi Peter.
>
> Good with more panel drivers.
> Some comments in the following, please do not blindly follow them but
> check that this is OK.
First of all, thank you for the review and sorry for the delay!
>
> Sam
>
> On Fri, Feb 15,
Hi Peter.
Good with more panel drivers.
Some comments in the following, please do not blindly follow them but
check that this is OK.
Sam
On Fri, Feb 15, 2019 at 04:03:15PM +0200, Peter Ujfalusi via dri-devel wrote:
> The panel is similar to OSD101T2045-53TS (which is handled by
The panel is similar to OSD101T2045-53TS (which is handled by panel-simple)
with one big difference: osd101t2587-53ts needs MIPI_DSI_TURN_ON_PERIPHERAL
message to be sent from the host to be operational and thus can not be
handled by panel-simple.
Signed-off-by: Peter Ujfalusi
---
7 matches
Mail list logo
