Re: [PATCH 4/4] exfat: standardize checksum calculation

2020-05-28 Thread Namjae Jeon
2020-05-28 19:09 GMT+09:00, Tetsuhiro Kohada : >>> I'll repost the patch, based on the dir-cache patched dev-tree. >>> If dir-cache patch will merge into dev-tree, should I wait until then? >> I will apply them after testing at once if you send updated 5 patches >> again. > > I resend patches for

Re: [PATCH 4/4] exfat: standardize checksum calculation

2020-05-28 Thread Tetsuhiro Kohada
I'll repost the patch, based on the dir-cache patched dev-tree. If dir-cache patch will merge into dev-tree, should I wait until then? I will apply them after testing at once if you send updated 5 patches again. I resend patches for boot_sector. However, the dir-cache patch hasn't changed, so

RE: [PATCH 4/4] exfat: standardize checksum calculation

2020-05-27 Thread Namjae Jeon
atches in the following order. > > 1. [PATCH] exfat: optimize dir-cache > > 2. [PATCH 1/4] exfat: redefine PBR as boot_sector 3. [PATCH 2/4] > > exfat: separate the boot sector analysis 4. [PATCH 3/4] exfat: add > > boot region verification 5. [PATCH 4/4] exfat: standardize c

Re: [PATCH 4/4] exfat: standardize checksum calculation

2020-05-27 Thread Tetsuhiro Kohada
] exfat: redefine PBR as boot_sector 3. [PATCH 2/4] exfat: separate the boot sector analysis 4. [PATCH 3/4] exfat: add boot region verification 5. [PATCH 4/4] exfat: standardize checksum calculation I was able to reproduce it. The dir-cache patch was created based on the HEAD of dev-tree. The 4

Re: [PATCH 4/4] exfat: standardize checksum calculation

2020-05-27 Thread Namjae Jeon
I can't reproduce the error. (Both succeed) > How do you reproduce the error? I tried to appy your patches in the following order. 1. [PATCH] exfat: optimize dir-cache 2. [PATCH 1/4] exfat: redefine PBR as boot_sector 3. [PATCH 2/4] exfat: separate the boot sector analysis 4. [PATCH 3/4] exfat: add boot region verification 5. [PATCH 4/4] exfat: standardize checksum calculation Thanks! > > BR >

Re: [PATCH 4/4] exfat: standardize checksum calculation

2020-05-27 Thread Tetsuhiro Kohada
Thank you for your comment. I can not apply this patch to exfat dev tree. Could you please check it ? patching file fs/exfat/dir.c Hunk #1 succeeded at 491 (offset -5 lines). Hunk #2 succeeded at 500 (offset -5 lines). Hunk #3 succeeded at 508 (offset -5 lines). Hunk #4 FAILED at 600. Hunk #5

RE: [PATCH 4/4] exfat: standardize checksum calculation

2020-05-26 Thread Namjae Jeon
> To clarify that it is a 16-bit checksum, the parts related to the 16-bit > checksum are renamed and > change type to u16. > Furthermore, replace checksum calculation in exfat_load_upcase_table() with > exfat_calc_checksum32(). > > Signed-off-by: Tetsuhiro Kohada I can not apply this patch

[PATCH 4/4] exfat: standardize checksum calculation

2020-05-25 Thread Tetsuhiro Kohada
To clarify that it is a 16-bit checksum, the parts related to the 16-bit checksum are renamed and change type to u16. Furthermore, replace checksum calculation in exfat_load_upcase_table() with exfat_calc_checksum32(). Signed-off-by: Tetsuhiro Kohada --- fs/exfat/dir.c | 12 ++--