Re: [PATCH 4/4] export: avoid code duplication in include/linux/export.h

2019-10-11 Thread Masahiro Yamada
On Sat, Oct 12, 2019 at 12:43 AM Matthias Maennich wrote: > > On Fri, Oct 11, 2019 at 05:31:27PM +0200, Greg Kroah-Hartman wrote: > >On Thu, Oct 10, 2019 at 04:14:43PM +0100, Matthias Maennich wrote: > >> Now that the namespace value is not part of the __ksymtab entry name > >> anymore, we can

Re: [PATCH 4/4] export: avoid code duplication in include/linux/export.h

2019-10-11 Thread Matthias Maennich
On Fri, Oct 11, 2019 at 05:31:27PM +0200, Greg Kroah-Hartman wrote: On Thu, Oct 10, 2019 at 04:14:43PM +0100, Matthias Maennich wrote: Now that the namespace value is not part of the __ksymtab entry name anymore, we can simplify the implementation of EXPORT_SYMBOL*. By allowing the empty string

Re: [PATCH 4/4] export: avoid code duplication in include/linux/export.h

2019-10-11 Thread Greg Kroah-Hartman
On Thu, Oct 10, 2019 at 04:14:43PM +0100, Matthias Maennich wrote: > Now that the namespace value is not part of the __ksymtab entry name > anymore, we can simplify the implementation of EXPORT_SYMBOL*. By > allowing the empty string "" to represent 'no namespace', we can unify > the

[PATCH 4/4] export: avoid code duplication in include/linux/export.h

2019-10-10 Thread Matthias Maennich
Now that the namespace value is not part of the __ksymtab entry name anymore, we can simplify the implementation of EXPORT_SYMBOL*. By allowing the empty string "" to represent 'no namespace', we can unify the implementation and drop a lot redundant code. That increases readability and