Re: [PATCH 4/4] fix not-and/or errors

2007-10-17 Thread Al Viro
On Wed, Oct 17, 2007 at 03:55:29PM +0200, Roel Kluin wrote: > if(!x & y) should either be if(!(x & y)) or if(!x && y) > I made changes as seemed appropriate, but please review > > Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> > --- > diff --git a/arch/arm/mach-pxa/mfp.c

Re: [PATCH 4/4] fix not-and/or errors

2007-10-17 Thread Peter Zijlstra
On Wed, 2007-10-17 at 15:55 +0200, Roel Kluin wrote: > if(!x & y) should either be if(!(x & y)) or if(!x && y) > I made changes as seemed appropriate, but please review > > Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> and 3 and 4 look good too.. - To unsubscribe from this list:

[PATCH 4/4] fix not-and/or errors

2007-10-17 Thread Roel Kluin
if(!x & y) should either be if(!(x & y)) or if(!x && y) I made changes as seemed appropriate, but please review Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> --- diff --git a/arch/arm/mach-pxa/mfp.c b/arch/arm/mach-pxa/mfp.c index 5cd3cad..7229319 100644 ---

[PATCH 4/4] fix not-and/or errors

2007-10-17 Thread Roel Kluin
if(!x y) should either be if(!(x y)) or if(!x y) I made changes as seemed appropriate, but please review Signed-off-by: Roel Kluin [EMAIL PROTECTED] --- diff --git a/arch/arm/mach-pxa/mfp.c b/arch/arm/mach-pxa/mfp.c index 5cd3cad..7229319 100644 --- a/arch/arm/mach-pxa/mfp.c

Re: [PATCH 4/4] fix not-and/or errors

2007-10-17 Thread Peter Zijlstra
On Wed, 2007-10-17 at 15:55 +0200, Roel Kluin wrote: if(!x y) should either be if(!(x y)) or if(!x y) I made changes as seemed appropriate, but please review Signed-off-by: Roel Kluin [EMAIL PROTECTED] and 3 and 4 look good too.. - To unsubscribe from this list: send the line

Re: [PATCH 4/4] fix not-and/or errors

2007-10-17 Thread Al Viro
On Wed, Oct 17, 2007 at 03:55:29PM +0200, Roel Kluin wrote: if(!x y) should either be if(!(x y)) or if(!x y) I made changes as seemed appropriate, but please review Signed-off-by: Roel Kluin [EMAIL PROTECTED] --- diff --git a/arch/arm/mach-pxa/mfp.c