Hi Alain,
> Ok, understood. Fine for me that way as well. I am just a little worrying that
> the "host-notify" can now be present in both controller AND slave nodes
> and might be a bit hard to understand. At the same time I don't have a better
> proposal for naming the binding for the
Hi Wolfram,
> I meant a generic binding for the host-controller. It could be seen as a
> HW description if we need HostNotify on that bus or not.
>
> Maybe it becomes more clear with the R-Car I2C controller as an example.
> It only supports one slave address. If I want HostNotify there, I can't
Hi Alain,
> > So, as mentioned in the other review, I'd like to evaluate other
> > possibilities for the above:
> >
> > - One option is to enable it globally in probe(). Then you lose the
> > possibility to have a device at address 0x08.
>
> I'd prefer avoid this solution to not lose the
On Sat, May 23, 2020 at 01:01:40PM +0200, Wolfram Sang wrote:
>
> > +static int stm32f7_i2c_reg_client(struct i2c_client *client)
> > +{
> > + struct stm32f7_i2c_dev *i2c_dev = i2c_get_adapdata(client->adapter);
> > + int ret;
> > +
> > + if (client->flags & I2C_CLIENT_HOST_NOTIFY) {
> > +
> +static int stm32f7_i2c_reg_client(struct i2c_client *client)
> +{
> + struct stm32f7_i2c_dev *i2c_dev = i2c_get_adapdata(client->adapter);
> + int ret;
> +
> + if (client->flags & I2C_CLIENT_HOST_NOTIFY) {
> + /* Only enable on the first device registration */
> +
Hi all,
Reviewed-by: Pierre-Yves MORDRET
Thanks
On 5/5/20 7:51 AM, Alain Volmat wrote:
> This patch adds the support for SMBus Host notify and SMBus Alert
> extensions protocols
>
> Signed-off-by: Alain Volmat
> ---
> drivers/i2c/busses/Kconfig | 1 +
>
This patch adds the support for SMBus Host notify and SMBus Alert
extensions protocols
Signed-off-by: Alain Volmat
---
drivers/i2c/busses/Kconfig | 1 +
drivers/i2c/busses/i2c-stm32f7.c | 198 +--
2 files changed, 189 insertions(+), 10 deletions(-)
diff
7 matches
Mail list logo
