From: Christoph Hellwig
Date: Mon, 18 May 2020 08:30:43 +0200
> I'll look into implenenting the tunnel_ctl method just for kernel
> callers (plus maybe a generic helper for the ioctl), and we'll see if
> you like that better.
Ok, thank you.
On Sat, May 16, 2020 at 01:55:48PM -0700, David Miller wrote:
> From: Christoph Hellwig
> Date: Fri, 15 May 2020 08:33:24 +0200
>
> > My initial plan was to add a ->tunnel_ctl method to the net_device_ops,
> > and lift the copy_{to,from}_user for SIOCADDTUNNEL, SIOCCHGTUNNEL,
> > SIOCDELTUNNEL an
From: Christoph Hellwig
Date: Fri, 15 May 2020 08:33:24 +0200
> My initial plan was to add a ->tunnel_ctl method to the net_device_ops,
> and lift the copy_{to,from}_user for SIOCADDTUNNEL, SIOCCHGTUNNEL,
> SIOCDELTUNNEL and maybe SIOCGETTUNNEL to net/socket.c. But that turned
> out to have two
On Thu, May 14, 2020 at 05:53:55PM -0700, David Miller wrote:
> You're not undoing one, but two levels of abstraction here.
>
> Is this "ipip6_tunnel_locate()" call part of the SIT ioctl implementation?
Yes. Take a look at the convoluted case handling the
SIOCADDTUNNEL and SIOCCHGTUNNEL commands
From: Christoph Hellwig
Date: Thu, 14 May 2020 16:51:01 +0200
> Instead of going through the ioctl handler from kernel space, use
> symbol_get to the newly factored out ipip6_set_dstaddr helper, bypassing
> addrconf.c entirely.
>
> Signed-off-by: Christoph Hellwig
...
> - memset(&p
Instead of going through the ioctl handler from kernel space, use
symbol_get to the newly factored out ipip6_set_dstaddr helper, bypassing
addrconf.c entirely.
Signed-off-by: Christoph Hellwig
---
include/net/addrconf.h | 1 -
include/net/ipv6.h | 2 ++
net/ipv6/addrconf.c| 66
6 matches
Mail list logo