Re: [PATCH 4/4] kvm, vmx: remove manually coded vmx instructions

2018-10-26 Thread Sean Christopherson
On Fri, Oct 26, 2018 at 10:46:27AM +, Stecklina, Julian wrote: > On Wed, 2018-10-24 at 10:44 -0700, Eric Northup wrote: > > This loses the exception handling from __ex* -> > > kvm_handle_fault_on_reboot. > > > > If deliberate, this should be called out in changelog.  Has the race > > which

Re: [PATCH 4/4] kvm, vmx: remove manually coded vmx instructions

2018-10-26 Thread Stecklina, Julian
On Wed, 2018-10-24 at 10:44 -0700, Eric Northup wrote: > This loses the exception handling from __ex* -> > kvm_handle_fault_on_reboot. > > If deliberate, this should be called out in changelog.  Has the race > which commit 4ecac3fd fixed been mitigated otherwise? No, this was not deliberate.

Re: [PATCH 4/4] kvm, vmx: remove manually coded vmx instructions

2018-10-24 Thread Eric Northup
On Wed, Oct 24, 2018 at 1:30 AM Julian Stecklina wrote: > > So far the VMX code relied on manually assembled VMX instructions. This > was apparently done to ensure compatibility with old binutils. VMX > instructions were introduced with binutils 2.19 and the kernel currently > requires binutils 2.

[PATCH 4/4] kvm, vmx: remove manually coded vmx instructions

2018-10-24 Thread Julian Stecklina
So far the VMX code relied on manually assembled VMX instructions. This was apparently done to ensure compatibility with old binutils. VMX instructions were introduced with binutils 2.19 and the kernel currently requires binutils 2.20. Remove the manually assembled versions and replace them with t