Re: [PATCH 4/4] libata: make libata use printk_header() and mprintk

2008-01-15 Thread Tejun Heo
Randy Dunlap wrote: >> -ata_dev_printk(dev, KERN_WARNING, >> -"Drive reports diagnostics failure. This may indicate a drive\n"); >> -ata_dev_printk(dev, KERN_WARNING, >> -"fault or invalid emulation. Contact drive vendor for information.\n"); >> -

Re: [PATCH 4/4] libata: make libata use printk_header() and mprintk

2008-01-15 Thread Randy Dunlap
On Wed, 16 Jan 2008 10:00:10 +0900 Tejun Heo wrote: > Reimplement libata printk helpers using printk_header, implement > helpers to initialize mprintk and use mprintk during device > configuration and EH reporting. > > This fixes various formatting related problems of libata messages such > as mi

[PATCH 4/4] libata: make libata use printk_header() and mprintk

2008-01-15 Thread Tejun Heo
Reimplement libata printk helpers using printk_header, implement helpers to initialize mprintk and use mprintk during device configuration and EH reporting. This fixes various formatting related problems of libata messages such as misaligned multiline messages, decoded register lines with leading