Re: [PATCH 4/4] mfd: as3722: introduce regmap support

2013-08-22 Thread Lee Jones
On Wed, 21 Aug 2013, Mark Brown wrote: > On Tue, Aug 20, 2013 at 01:08:00PM +0100, Lee Jones wrote: > > On Tue, 20 Aug 2013, Florian Lobmaier wrote: > > > > Signed-off-by: Florian Lobmaier > > > --- > > > drivers/mfd/as3722-regmap.c | 417 > > > +++ > >

Re: [PATCH 4/4] mfd: as3722: introduce regmap support

2013-08-22 Thread Lee Jones
On Wed, 21 Aug 2013, Mark Brown wrote: On Tue, Aug 20, 2013 at 01:08:00PM +0100, Lee Jones wrote: On Tue, 20 Aug 2013, Florian Lobmaier wrote: Signed-off-by: Florian Lobmaier florian.lobma...@ams.com --- drivers/mfd/as3722-regmap.c | 417

Re: [PATCH 4/4] mfd: as3722: introduce regmap support

2013-08-21 Thread Mark Brown
On Tue, Aug 20, 2013 at 01:13:30PM +0200, Florian Lobmaier wrote: > +static bool as3722_readable(struct device *dev, unsigned int reg) > +{ > + switch (reg) { > + case AS3722_SD0_VOLTAGE_REG: > + case AS3722_SD1_VOLTAGE_REG: If there are no gaps in this a simple if ( >= <= ) would do

Re: [PATCH 4/4] mfd: as3722: introduce regmap support

2013-08-21 Thread Mark Brown
On Tue, Aug 20, 2013 at 01:08:00PM +0100, Lee Jones wrote: > On Tue, 20 Aug 2013, Florian Lobmaier wrote: > > Signed-off-by: Florian Lobmaier > > --- > > drivers/mfd/as3722-regmap.c | 417 > > +++ > > 1 files changed, 417 insertions(+), 0 deletions(-) >

Re: [PATCH 4/4] mfd: as3722: introduce regmap support

2013-08-21 Thread Mark Brown
On Tue, Aug 20, 2013 at 01:08:00PM +0100, Lee Jones wrote: On Tue, 20 Aug 2013, Florian Lobmaier wrote: Signed-off-by: Florian Lobmaier florian.lobma...@ams.com --- drivers/mfd/as3722-regmap.c | 417 +++ 1 files changed, 417 insertions(+), 0

Re: [PATCH 4/4] mfd: as3722: introduce regmap support

2013-08-21 Thread Mark Brown
On Tue, Aug 20, 2013 at 01:13:30PM +0200, Florian Lobmaier wrote: +static bool as3722_readable(struct device *dev, unsigned int reg) +{ + switch (reg) { + case AS3722_SD0_VOLTAGE_REG: + case AS3722_SD1_VOLTAGE_REG: If there are no gaps in this a simple if ( = = ) would do - the

Re: [PATCH 4/4] mfd: as3722: introduce regmap support

2013-08-20 Thread Lee Jones
On Tue, 20 Aug 2013, Florian Lobmaier wrote: > > Signed-off-by: Florian Lobmaier > --- > drivers/mfd/as3722-regmap.c | 417 > +++ > 1 files changed, 417 insertions(+), 0 deletions(-) > create mode 100644 drivers/mfd/as3722-regmap.c I'll leave the

[PATCH 4/4] mfd: as3722: introduce regmap support

2013-08-20 Thread Florian Lobmaier
Signed-off-by: Florian Lobmaier --- drivers/mfd/as3722-regmap.c | 417 +++ 1 files changed, 417 insertions(+), 0 deletions(-) create mode 100644 drivers/mfd/as3722-regmap.c diff --git a/drivers/mfd/as3722-regmap.c b/drivers/mfd/as3722-regmap.c new file

[PATCH 4/4] mfd: as3722: introduce regmap support

2013-08-20 Thread Florian Lobmaier
Signed-off-by: Florian Lobmaier florian.lobma...@ams.com --- drivers/mfd/as3722-regmap.c | 417 +++ 1 files changed, 417 insertions(+), 0 deletions(-) create mode 100644 drivers/mfd/as3722-regmap.c diff --git a/drivers/mfd/as3722-regmap.c

Re: [PATCH 4/4] mfd: as3722: introduce regmap support

2013-08-20 Thread Lee Jones
On Tue, 20 Aug 2013, Florian Lobmaier wrote: Signed-off-by: Florian Lobmaier florian.lobma...@ams.com --- drivers/mfd/as3722-regmap.c | 417 +++ 1 files changed, 417 insertions(+), 0 deletions(-) create mode 100644 drivers/mfd/as3722-regmap.c