Re: [PATCH 4/4] mm: Increase SWAP_CLUSTER_MAX to batch TLB flushes

2015-07-13 Thread Andrew Morton
On Thu, 9 Jul 2015 09:14:25 +0100 Mel Gorman wrote: > Overall, I would say that none of these workloads justify the patch on > its own. Reducing IPIs further is nice but we got the bulk of the > benefit from the two batching patches and after that other factors > dominate. Based on the results I

Re: [PATCH 4/4] mm: Increase SWAP_CLUSTER_MAX to batch TLB flushes

2015-07-13 Thread Andrew Morton
On Thu, 9 Jul 2015 09:14:25 +0100 Mel Gorman mgor...@suse.de wrote: Overall, I would say that none of these workloads justify the patch on its own. Reducing IPIs further is nice but we got the bulk of the benefit from the two batching patches and after that other factors dominate. Based on

Re: [PATCH 4/4] mm: Increase SWAP_CLUSTER_MAX to batch TLB flushes

2015-07-09 Thread Mel Gorman
On Tue, Jul 07, 2015 at 04:25:26PM -0700, Andrew Morton wrote: > On Mon, 6 Jul 2015 14:39:56 +0100 Mel Gorman wrote: > > > Pages that are unmapped for reclaim must be flushed before being freed to > > avoid corruption due to a page being freed and reallocated while a stale > > TLB entry exists.

Re: [PATCH 4/4] mm: Increase SWAP_CLUSTER_MAX to batch TLB flushes

2015-07-09 Thread Mel Gorman
On Tue, Jul 07, 2015 at 04:25:26PM -0700, Andrew Morton wrote: On Mon, 6 Jul 2015 14:39:56 +0100 Mel Gorman mgor...@suse.de wrote: Pages that are unmapped for reclaim must be flushed before being freed to avoid corruption due to a page being freed and reallocated while a stale TLB entry

Re: [PATCH 4/4] mm: Increase SWAP_CLUSTER_MAX to batch TLB flushes

2015-07-07 Thread Andrew Morton
On Mon, 6 Jul 2015 14:39:56 +0100 Mel Gorman wrote: > Pages that are unmapped for reclaim must be flushed before being freed to > avoid corruption due to a page being freed and reallocated while a stale > TLB entry exists. When reclaiming mapped pages, the requires one IPI per >

Re: [PATCH 4/4] mm: Increase SWAP_CLUSTER_MAX to batch TLB flushes

2015-07-07 Thread Andrew Morton
On Mon, 6 Jul 2015 14:39:56 +0100 Mel Gorman mgor...@suse.de wrote: Pages that are unmapped for reclaim must be flushed before being freed to avoid corruption due to a page being freed and reallocated while a stale TLB entry exists. When reclaiming mapped pages, the requires one IPI per

[PATCH 4/4] mm: Increase SWAP_CLUSTER_MAX to batch TLB flushes

2015-07-06 Thread Mel Gorman
Pages that are unmapped for reclaim must be flushed before being freed to avoid corruption due to a page being freed and reallocated while a stale TLB entry exists. When reclaiming mapped pages, the requires one IPI per SWAP_CLUSTER_MAX. This patch increases SWAP_CLUSTER_MAX to 256 so more pages

[PATCH 4/4] mm: Increase SWAP_CLUSTER_MAX to batch TLB flushes

2015-07-06 Thread Mel Gorman
Pages that are unmapped for reclaim must be flushed before being freed to avoid corruption due to a page being freed and reallocated while a stale TLB entry exists. When reclaiming mapped pages, the requires one IPI per SWAP_CLUSTER_MAX. This patch increases SWAP_CLUSTER_MAX to 256 so more pages