Re: [PATCH 4/4] perf stat: Add transaction flag (-T) support for s390

2018-06-22 Thread Andi Kleen
> > > > You may need to add support for wildcard pmus to it. > > > > -Andi > > > > Currently only one PMU on s390 does support transactions, its the PMU with > counters > named cpum_cf. Right, but you don't want to hard code that pmu into builtin-stat. -Andi

Re: [PATCH 4/4] perf stat: Add transaction flag (-T) support for s390

2018-06-22 Thread Thomas-Mich Richter
On 06/22/2018 04:36 AM, Andi Kleen wrote: > Thomas Richter writes: >> >> +/* Handle -T as -M transaction. Once platform specific metrics >> + * support has been added to the json files, all archiectures >> + * will use this approach. >> + */ >> +

Re: [PATCH 4/4] perf stat: Add transaction flag (-T) support for s390

2018-06-21 Thread Andi Kleen
Thomas Richter writes: > > + /* Handle -T as -M transaction. Once platform specific metrics > + * support has been added to the json files, all archiectures > + * will use this approach. > + */ > + if (!strcmp(perf_env__arch(NULL), "

[PATCH 4/4] perf stat: Add transaction flag (-T) support for s390

2018-06-21 Thread Thomas Richter
perf stat command line flag -T to display transaction counters is currently supported for x86 only. Add support for s390. It is based on the metrics flag -M transaction using the architecture dependend json files This requires a metric named transaction in the json files for the platform. As sugge