Re: [PATCH 4/4] perf tools: Retry mapping buffers readonly on EACCES

2013-06-14 Thread Robert Richter
On 14.06.13 11:08:40, Namhyung Kim wrote: > > - if (perf_evlist__mmap(evlist, opts->mmap_pages, false) < 0) { > > +try_again2: > > + if (perf_evlist__mmap(evlist, opts->mmap_pages, opts->mmap_ro) < 0) { > > + if (!opts->mmap_ro && errno == EACCES) { > > +

Re: [PATCH 4/4] perf tools: Retry mapping buffers readonly on EACCES

2013-06-14 Thread Robert Richter
On 14.06.13 11:08:40, Namhyung Kim wrote: - if (perf_evlist__mmap(evlist, opts-mmap_pages, false) 0) { +try_again2: + if (perf_evlist__mmap(evlist, opts-mmap_pages, opts-mmap_ro) 0) { + if (!opts-mmap_ro errno == EACCES) { + opts-mmap_ro = true; +

Re: [PATCH 4/4] perf tools: Retry mapping buffers readonly on EACCES

2013-06-13 Thread Namhyung Kim
Hi Robert, On Fri, 31 May 2013 11:16:25 +0200, Robert Richter wrote: > From: Robert Richter > > Persistent event buffers may only be mmapped readonly. Thus, retry > mapping it readonly if mmap returns EACCES after trying to mmap > writable. > > Signed-off-by: Robert Richter > --- >

Re: [PATCH 4/4] perf tools: Retry mapping buffers readonly on EACCES

2013-06-13 Thread Namhyung Kim
Hi Robert, On Fri, 31 May 2013 11:16:25 +0200, Robert Richter wrote: From: Robert Richter robert.rich...@calxeda.com Persistent event buffers may only be mmapped readonly. Thus, retry mapping it readonly if mmap returns EACCES after trying to mmap writable. Signed-off-by: Robert Richter

[PATCH 4/4] perf tools: Retry mapping buffers readonly on EACCES

2013-05-31 Thread Robert Richter
From: Robert Richter Persistent event buffers may only be mmapped readonly. Thus, retry mapping it readonly if mmap returns EACCES after trying to mmap writable. Signed-off-by: Robert Richter --- tools/perf/builtin-record.c | 7 ++- tools/perf/builtin-top.c| 8 ++--

[PATCH 4/4] perf tools: Retry mapping buffers readonly on EACCES

2013-05-31 Thread Robert Richter
From: Robert Richter robert.rich...@calxeda.com Persistent event buffers may only be mmapped readonly. Thus, retry mapping it readonly if mmap returns EACCES after trying to mmap writable. Signed-off-by: Robert Richter robert.rich...@calxeda.com --- tools/perf/builtin-record.c | 7 ++-